Summary: | Unnecessary holds fetch in serials/routing-preview.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 31335: Remove unnecessary holds fetch from routing-preview
Bug 31335: Remove unnecessary holds fetch from routing-preview Bug 31335: Remove unnecessary holds fetch from routing-preview |
Description
Jonathan Druart
2022-08-10 10:33:25 UTC
Created attachment 138970 [details] [review] Bug 31335: Remove unnecessary holds fetch from routing-preview This $count variable is not used later, and I didn't find why it was there in previous versions. Test plan: Use `git log -p serials/routing-preview.pl` and confirm we can remove this block Created attachment 163525 [details] [review] Bug 31335: Remove unnecessary holds fetch from routing-preview This $count variable is not used later, and I didn't find why it was there in previous versions. Test plan: Use `git log -p serials/routing-preview.pl` and confirm we can remove this block Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 164594 [details] [review] Bug 31335: Remove unnecessary holds fetch from routing-preview This $count variable is not used later, and I didn't find why it was there in previous versions. Test plan: Use `git log -p serials/routing-preview.pl` and confirm we can remove this block Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial clear fix, Passing QA (In reply to Martin Renvoize from comment #4) > Trivial clear fix, Passing QA But took 1.5 year :D Pushed for 24.05! Well done everyone, thank you! Not backported to 23.11.x Architecture change, nothing to add/edit in the Koha manual. |