| Summary: | In-progress background jobs give incorrect progress message | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 31245 | ||
| Bug Blocks: | 35092 | ||
|
Description
Andrew Fuerste-Henry
2022-08-10 13:33:12 UTC
Also true for deletion "All records have been deleted successfully!” I rise to major importance, this could lead to misunderstanding. I see in template : [% IF job.status != 'new' %][% PROCESS 'report' %][% END %] https://git.koha-community.org/Koha-community/Koha/src/commit/9c565eff1357c2fdf900f006a17fa62fd4f2f9ee/koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt#L99 Should we simply change for job.status finished, canceled or failed ? Also : I see some templates are managing the cancel status : https://git.koha-community.org/Koha-community/Koha/src/commit/00e33f875808761e6a280778842fd28bd5ab27d9/koha-tmpl/intranet-tmpl/prog/en/includes/background_jobs/batch_biblio_record_modification.inc#L24 It is missing in batch biblio record deletion. Maybe we should change includes to define "report_sucess", "report_canceled" ... Ah also I see the template uses :
[% SET report = job.report %]
[% IF report %]
But job.report returns empty hashref :
https://git.koha-community.org/Koha-community/Koha/src/commit/2eca0fe3632bf0ec4396da0c694b9fdbddf9e4df/Koha/BackgroundJob.pm#L339
May we return undef ?
|