| Summary: | DataTables error on waitingreserves.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, gmcharlt, jonathan.druart, kyle.m.hall, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 22456, 31138 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 31343: (bug 31138 follow-up) Don't hide error
Bug 31343: Prevent two nodes #holdscr on waiting reserves Bug 31343: (bug 31138 follow-up) Don't hide error Bug 31343: Prevent two nodes #holdscr on waiting reserves Bug 31343: (bug 31138 follow-up) Don't hide error Bug 31343: Prevent two nodes #holdscr on waiting reserves |
||
|
Description
Lucas Gass (lukeg)
2022-08-11 17:57:09 UTC
This is caused by Bug 31138. I don't think I understand why that change was made. (In reply to Owen Leonard from comment #1) > This is caused by Bug 31138. I don't think I understand why that change was > made. To catch errors or mistakes, see bug 31138 comment 0. It is more obvious when you have an error server-side: the table was empty with nothing to tell the user that something wrong happened. Created attachment 139048 [details] [review] Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden Created attachment 139049 [details] [review] Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. (In reply to Jonathan Druart from comment #2) > (In reply to Owen Leonard from comment #1) > > This is caused by Bug 31138. I don't think I understand why that change was > > made. > > To catch errors or mistakes, see bug 31138 comment 0. > It is more obvious when you have an error server-side: the table was empty > with nothing to tell the user that something wrong happened. And here it caught a mistake ;) Created attachment 139053 [details] [review] Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 139054 [details] [review] Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 139499 [details] [review] Bug 31343: (bug 31138 follow-up) Don't hide error Some errors are not passing settings and so the error is hidden Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 139500 [details] [review] Bug 31343: Prevent two nodes #holdscr on waiting reserves Two nodes with id="holdscr" existed on this patch. I guess the table was not initiated properly before 31138 neither. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! Missing 22.05.x dependencies, no backport |