| Summary: | Separate holds history from intranetreadinghistory | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Donna <bwsdonna> |
| Component: | Patrons | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, nick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/916 |
| Text to go in the release notes: | Version(s) released in: |
23.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 35183 | ||
| Attachments: |
Bug 31357: Separate holds history from intranetreadinghistory
Bug 31357: Separate holds history from intranetreadinghistory Bug 31357: Separate holds history from intranetreadinghistory |
||
|
Description
Donna
2022-08-12 20:44:30 UTC
Created attachment 152875 [details] [review] Bug 31357: Separate holds history from intranetreadinghistory Currently the system preference intranetreadinghistory determines visibility of both circulation history and holds history tabs in the patron record. It would be helpful to allow the option of setting each of those independently. Specifically, libraries have requested the option of being able to view the holds history in a patron record without having to enable viewing of the circulation history. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Run updatadatabase.pl 4) Verify the new syspref intranetReadingHistoryHolds has the same value as the existing syspref intranetreadinghistory 5) Disable intranetreadinghistory, enable intranetReadingHistoryHolds 6) Verify you can view a patron's holds history but not reading history Created attachment 152877 [details] [review] Bug 31357: Separate holds history from intranetreadinghistory Currently the system preference intranetreadinghistory determines visibility of both circulation history and holds history tabs in the patron record. It would be helpful to allow the option of setting each of those independently. Specifically, libraries have requested the option of being able to view the holds history in a patron record without having to enable viewing of the circulation history. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Run updatadatabase.pl 4) Verify the new syspref intranetReadingHistoryHolds has the same value as the existing syspref intranetreadinghistory 5) Disable intranetreadinghistory, enable intranetReadingHistoryHolds 6) Verify you can view a patron's holds history but not reading history Signed-off-by: Sam Lau <samalau@gmail.com> Created attachment 156547 [details] [review] Bug 31357: Separate holds history from intranetreadinghistory Currently the system preference intranetreadinghistory determines visibility of both circulation history and holds history tabs in the patron record. It would be helpful to allow the option of setting each of those independently. Specifically, libraries have requested the option of being able to view the holds history in a patron record without having to enable viewing of the circulation history. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Run updatadatabase.pl 4) Verify the new syspref intranetReadingHistoryHolds has the same value as the existing syspref intranetreadinghistory 5) Disable intranetreadinghistory, enable intranetReadingHistoryHolds 6) Verify you can view a patron's holds history but not reading history Signed-off-by: Sam Lau <samalau@gmail.com> JD amended patch: * renamed syspref intranetReadingHistoryHolds => IntranetReadingHistoryHolds * tidy Kyle, I have renamed the pref to make it start with an uppercase. Hope you agree with that (otherwise say it and I will resubmit). It seems more inline with what we have already. It would be nice to rename intranetreadinghistory with IntranetReadingHistory for the same release. (In reply to Jonathan Druart from comment #4) > Kyle, I have renamed the pref to make it start with an uppercase. Hope you > agree with that (otherwise say it and I will resubmit). It seems more inline > with what we have already. A bit belated, but yes, I have no problem with that! Many hands make light work! Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x (In reply to Jonathan Druart from comment #5) > It would be nice to rename intranetreadinghistory with > IntranetReadingHistory for the same release. Filed as: Bug 35183 - Rename [opac|intranet]readinghistory to [Opac/Intranet]ReadingHistory Turns out not quite as easy as we also should take care of opacreadinghistory at the same time. |