Bug 31357

Summary: Separate holds history from intranetreadinghistory
Product: Koha Reporter: Donna <bwsdonna>
Component: PatronsAssignee: Kyle M Hall <kyle>
Status: Needs documenting --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, nick
Version: MainKeywords: release-notes-needed
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Bug Depends on:    
Bug Blocks: 35183    
Attachments: Bug 31357: Separate holds history from intranetreadinghistory
Bug 31357: Separate holds history from intranetreadinghistory
Bug 31357: Separate holds history from intranetreadinghistory

Description Donna 2022-08-12 20:44:30 UTC
Currently the system preference intranetreadinghistory determines visibility of both circulation history and holds history tabs in the patron record.  It would be helpful to allow the option of setting each of those independently.  

Specifically, libraries have requested the option of being able to view the holds history in a patron record without having to enable viewing of the circulation history.
Comment 1 Kyle M Hall 2023-06-29 18:20:38 UTC
Created attachment 152875 [details] [review]
Bug 31357: Separate holds history from intranetreadinghistory

Currently the system preference intranetreadinghistory determines visibility of both circulation history and holds history tabs in the patron record.  It would be helpful to allow the option of setting each of those independently.

Specifically, libraries have requested the option of being able to view the holds history in a patron record without having to enable viewing of the circulation history.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Run updatadatabase.pl
4) Verify the new syspref intranetReadingHistoryHolds has the same value
   as the existing syspref intranetreadinghistory
5) Disable intranetreadinghistory, enable intranetReadingHistoryHolds
6) Verify you can view a patron's holds history but not reading history
Comment 2 Sam Lau 2023-06-29 18:31:08 UTC
Created attachment 152877 [details] [review]
Bug 31357: Separate holds history from intranetreadinghistory

Currently the system preference intranetreadinghistory determines visibility of both circulation history and holds history tabs in the patron record.  It would be helpful to allow the option of setting each of those independently.

Specifically, libraries have requested the option of being able to view the holds history in a patron record without having to enable viewing of the circulation history.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Run updatadatabase.pl
4) Verify the new syspref intranetReadingHistoryHolds has the same value
   as the existing syspref intranetreadinghistory
5) Disable intranetreadinghistory, enable intranetReadingHistoryHolds
6) Verify you can view a patron's holds history but not reading history

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Jonathan Druart 2023-10-04 14:11:36 UTC
Created attachment 156547 [details] [review]
Bug 31357: Separate holds history from intranetreadinghistory

Currently the system preference intranetreadinghistory determines visibility of both circulation history and holds history tabs in the patron record.  It would be helpful to allow the option of setting each of those independently.

Specifically, libraries have requested the option of being able to view the holds history in a patron record without having to enable viewing of the circulation history.

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Run updatadatabase.pl
4) Verify the new syspref intranetReadingHistoryHolds has the same value
   as the existing syspref intranetreadinghistory
5) Disable intranetreadinghistory, enable intranetReadingHistoryHolds
6) Verify you can view a patron's holds history but not reading history

Signed-off-by: Sam Lau <samalau@gmail.com>

JD amended patch:
* renamed syspref intranetReadingHistoryHolds => IntranetReadingHistoryHolds
* tidy
Comment 4 Jonathan Druart 2023-10-04 14:12:21 UTC
Kyle, I have renamed the pref to make it start with an uppercase. Hope you agree with that (otherwise say it and I will resubmit). It seems more inline with what we have already.
Comment 5 Jonathan Druart 2023-10-04 14:12:49 UTC
It would be nice to rename intranetreadinghistory with IntranetReadingHistory for the same release.
Comment 6 Kyle M Hall 2023-10-11 10:51:43 UTC
(In reply to Jonathan Druart from comment #4)
> Kyle, I have renamed the pref to make it start with an uppercase. Hope you
> agree with that (otherwise say it and I will resubmit). It seems more inline
> with what we have already.

A bit belated, but yes, I have no problem with that! Many hands make light work!
Comment 7 Tomás Cohen Arazi 2023-10-20 19:32:03 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-10-26 06:17:47 UTC
Enhancement not pushed to 23.05.x
Comment 9 Katrin Fischer 2023-10-29 11:06:24 UTC
(In reply to Jonathan Druart from comment #5)
> It would be nice to rename intranetreadinghistory with
> IntranetReadingHistory for the same release.

Filed as:
Bug 35183 - Rename [opac|intranet]readinghistory to [Opac/Intranet]ReadingHistory 

Turns out not quite as easy as we also should take care of opacreadinghistory at the same time.