Description
Lucas Gass
2022-08-16 20:16:25 UTC
Created attachment 139212 [details] [review] Bug 31374: Database/Schema update Created attachment 139213 [details] [review] Bug 31374: Add non-public note to template Created attachment 139214 [details] [review] Bug 31374: Add privatenote column to table settings Created attachment 139216 [details] [review] Bug 31374: Update API spec Created attachment 139508 [details] [review] Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC Created attachment 139526 [details] [review] Bug 31374: Database/Schema update Signed-off-by: David Nind <david@davidnind.com> Created attachment 139527 [details] [review] Bug 31374: Add non-public note to template Signed-off-by: David Nind <david@davidnind.com> Created attachment 139528 [details] [review] Bug 31374: Add privatenote column to table settings Signed-off-by: David Nind <david@davidnind.com> Created attachment 139529 [details] [review] Bug 31374: Update API spec Signed-off-by: David Nind <david@davidnind.com> Created attachment 139530 [details] [review] Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC Signed-off-by: David Nind <david@davidnind.com> Testing notes (using koha-testing-docker): - For step 1 in the test plan, run the updatedatabase command as well. Hi Lucas, could we discuss renaming the database column? It's now: privatenote We don't use private as a term in any of the other tables or the GUI so I am hesitating to use completely new terminology here. What about: staff_note? If I see correctly we already have some of those in kohastructure.sql git grep note *.sql The second thing is me wondering if we should keep the status as the last column of the table, moving the new column forward by one. ... happy to hear your thoughts about that one! Otherwise this works really well! Cait, Thanks for looking at this one. I was unsure when I named the DB column privatenote, I am happy to change it to 'staff_note'. As for the order of where the column lives, I sort of arbitrarily put it where I put it. I will move it to be right before 'Status'? Created attachment 139627 [details] [review] Bug 31374: (follow-up) change private note to staff_note and reorder columns Since I only changed the column names I am keeping David's sign-off and setting this one to 'Signed-off'. Created attachment 139858 [details] [review] Bug 31374: Database/Schema update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 139859 [details] [review] Bug 31374: Add non-public note to template Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 139860 [details] [review] Bug 31374: Add privatenote column to table settings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 139861 [details] [review] Bug 31374: Update API spec Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 139862 [details] [review] Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 139863 [details] [review] Bug 31374: (follow-up) change private note to staff_note and reorder columns Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 139864 [details] [review] Bug 31374: (QA follow-up) Fix typo collumn in database update Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be backported to the 22.05.x series *** Bug 23134 has been marked as a duplicate of this bug. *** |