Bug 31377

Summary: Add basket's internal note to tables on vendor search result list
Product: Koha Reporter: Lucas Gass <lucas>
Component: AcquisitionsAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: andrewfh, caroline.cyr-la-rose
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31430
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/631
Text to go in the release notes:
Version(s) released in:
22.11.00
Attachments: Bug 31377: Add internal note column to booksellers.tt
Bug 31377: Add internal note column to booksellers.tt
Bug 31377: Add internal note column to booksellers.tt

Description Lucas Gass 2022-08-16 22:24:16 UTC
Some libraries would find it handy if the internal note (aqbasket.note) was a column on booksellers.pl
Comment 1 Lucas Gass 2022-08-16 22:27:04 UTC
Created attachment 139219 [details] [review]
Bug 31377: Add internal note column to booksellers.tt

To test:
-Apply patch
-Add some vendors and give them an internal note
-Go to /cgi-bin/koha/acqui/booksellers.pl
-Notice that there is a column which includes the internal note
Comment 2 Andrew Fuerste-Henry 2022-08-18 19:47:39 UTC
We're making the basket internal note visible here, right? Not the vendor note? The test plan contained what I think was an error. Here's what I did:

To test:
-Apply patch
-Add some BASKETS and give them an internal note
-Go to /cgi-bin/koha/acqui/booksellers.pl
-Notice that there is a column which includes the internal note
Comment 3 ByWater Sandboxes 2022-08-18 19:48:13 UTC
Created attachment 139415 [details] [review]
Bug 31377: Add internal note column to booksellers.tt

To test:
-Apply patch
-Add some vendors and give them an internal note
-Go to /cgi-bin/koha/acqui/booksellers.pl
-Notice that there is a column which includes the internal note

Signed-off-by: Andrew Fuerste-Henry <andrewfh@gmail.com>
Comment 4 Lucas Gass 2022-08-18 19:49:40 UTC
Andrew,

Thanks. Yes, I meant BASKET not vendor.
Comment 5 Katrin Fischer 2022-08-20 09:20:51 UTC
Created attachment 139538 [details] [review]
Bug 31377: Add internal note column to booksellers.tt

To test:
-Apply patch
-Add some vendors and give them an internal note
-Go to /cgi-bin/koha/acqui/booksellers.pl
-Notice that there is a column which includes the internal note

Signed-off-by: Andrew Fuerste-Henry <andrewfh@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-08-22 16:19:12 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-10-14 19:55:56 UTC
Enhancement will not be backported to 22.05.x series