Bug 31404

Summary:	Update circulation sidebar to match circulation start page
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Isobel Graham <isobel.graham09>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	enhancement
Priority:	P5 - low	CC:	lucas, martin.renvoize
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31403
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00
Circulation function:
Attachments:	Bug 31404: Sync Circulation sidebar with Circulation home Bug 31404: Sync Circulation sidebar with Circulation home Bug 31404: Sync Circulation sidebar with Circulation home Bug 31404: (QA follow-up) Mostly whitespace fixes

Description Katrin Fischer 2022-08-18 21:46:37 UTC

There are some discrepancies between the circuation sidebar (activated by CircSidebar) and the circulation start page:

* Headings don't match up: Holds, transfers and overdues are missing
* Transfer needs to be moved under transfers heading
* Transfers to send is missing

Comment 1 Isobel Graham 2022-08-31 15:16:23 UTC

Created attachment 140006 [details] [review]
Bug 31404: Sync Circulation sidebar with Circulation home

This patch syncs the content of the circulation sidebar navigation with
the content of the circulation homepage

Test plan
1. Enable the `CircSidebar` system preference
2. Compare the sidebar navigation on circulation pages with the content
   of the circulation homepage.

Comment 2 Owen Leonard 2022-09-02 16:25:38 UTC

Created attachment 140167 [details] [review]
Bug 31404: Sync Circulation sidebar with Circulation home

This patch syncs the content of the circulation sidebar navigation with
the content of the circulation homepage

Test plan
1. Enable the `CircSidebar` system preference
2. Compare the sidebar navigation on circulation pages with the content
   of the circulation homepage.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Comment 3 Katrin Fischer 2022-09-07 12:41:14 UTC

Created attachment 140278 [details] [review]
Bug 31404: Sync Circulation sidebar with Circulation home

This patch syncs the content of the circulation sidebar navigation with
the content of the circulation homepage

Test plan
1. Enable the `CircSidebar` system preference
2. Compare the sidebar navigation on circulation pages with the content
   of the circulation homepage.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Katrin Fischer 2022-09-07 12:41:18 UTC

Created attachment 140279 [details] [review]
Bug 31404: (QA follow-up) Mostly whitespace fixes

* Removed the leading space from the new entries as this could
  lead to another string to translate and they are not needed
* Removed some doubled up whitespaces from the <a> tags and
  a stray -
* Removed title from Article requests since it was the same text
  as the link itself, not adding information

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Katrin Fischer 2022-09-07 12:46:21 UTC

Nice clean-up, thx Isobel! 

I have provided a small follow-up fixing some whitespace issues. I know spaces don't seem so important, but in programming one character often can make a big difference. In this case I was worried it might affect translations. We have to translate every string in Koha and often the only difference between 'the same' string might be a leading or trailing space, capitalization etc. 

Please keep the patches coming!

Comment 6 Tomás Cohen Arazi (tcohen) 2022-09-07 20:30:48 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 7 Lucas Gass (lukeg) 2022-10-31 19:42:29 UTC

Doesn't apply cleanly to 22.05.x so it will not be included in the 22.05.x series