Summary: | Add accesskeys to recall modal | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens <nick> |
Component: | Circulation | Assignee: | Nick Clemens <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, gmcharlt, kyle.m.hall, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20688 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26626 |
||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Bug Depends on: | 29734 | ||
Bug Blocks: | |||
Attachments: |
Bug 31419: Add accesskeys for modals
Bug 31419: Add accesskeys for modals Bug 31419: Add accesskeys for modals |
Description
Nick Clemens
2022-08-19 10:04:26 UTC
Created attachment 139473 [details] [review] Bug 31419: Add accesskeys for modals This patch simply adds accesskey elements to the buttons, and changes an icon to be consistent with bug 26626 For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Generate a recall 2 - Fill it/check in 3 - Note modal now has hints "Confirm (Y)" 4 - Test with Y,P,I keys (may need to recreate recalls) 5 - Confirm the recall and test waiting recall modal too Created attachment 139562 [details] [review] Bug 31419: Add accesskeys for modals This patch simply adds accesskey elements to the buttons, and changes an icon to be consistent with bug 26626 For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Generate a recall 2 - Fill it/check in 3 - Note modal now has hints "Confirm (Y)" 4 - Test with Y,P,I keys (may need to recreate recalls) 5 - Confirm the recall and test waiting recall modal too Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 140957 [details] [review] Bug 31419: Add accesskeys for modals This patch simply adds accesskey elements to the buttons, and changes an icon to be consistent with bug 26626 For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey To test: 1 - Generate a recall 2 - Fill it/check in 3 - Note modal now has hints "Confirm (Y)" 4 - Test with Y,P,I keys (may need to recreate recalls) 5 - Confirm the recall and test waiting recall modal too Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! |