|
Description
Katrin Fischer
2022-08-19 15:02:47 UTC
*** Bug 31686 has been marked as a duplicate of this bug. *** Created attachment 141468 [details] [review] Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! Created attachment 141479 [details] [review] Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! Signed-off-by: David Nind <david@davidnind.com> Non-limited categories is displayed in the "New patron" dropdown list https://snipboard.io/043TZt.jpg > The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Is that correct? Yes I know I am the one who wrote bug 7919, but not the one who design it. And I have to admit I have no idea how it's supposed to work right now... (In reply to Jonathan Druart from comment #4) > Non-limited categories is displayed in the "New patron" dropdown list Sorry, *limited* categories. Created attachment 142247 [details] [review] Bug 31421: Add a limited option to template plugin This adds a specific 'limited' routine to the Categories plugin, and uses it for the new patron dropdowns To test: 1 - Limit a patron category to some branches 2 - Sign in not at one of those 3 - Confirm the new patron dropdowns don't include the category FAIL Koha/Template/Plugin/Categories.pm
OK critic
OK forbidden patterns
OK git manipulation
OK pod
FAIL pod coverage
POD is missing for 'limited'
Created attachment 142332 [details] [review] Bug 31421: (follow-up) Add POD Created attachment 142705 [details] [review] Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 142706 [details] [review] Bug 31421: Add a limited option to template plugin This adds a specific 'limited' routine to the Categories plugin, and uses it for the new patron dropdowns To test: 1 - Limit a patron category to some branches 2 - Sign in not at one of those 3 - Confirm the new patron dropdowns don't include the category Bug 31421: (follow-up) Add POD Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 142707 [details] [review] Bug 31421: Add tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.07 release applied to 21.11.x for 21.11.14 21.05.x not affected, no backport. Nothing to document it seems, marking resolved. revert on 21.11. bug actually not reproduced. |
