Bug 31436

Summary: AllowRenewalIfOtherItemsAvailable should not take suspended holds into account
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: CirculationAssignee: Kyle M Hall (khall) <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, joonas.kylmala, kyle.m.hall
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 31112    
Bug Blocks:    
Attachments: Bug 31436: AllowRenewalIfOtherItemsAvailable should not take suspended holds into account

Description Kyle M Hall (khall) 2022-08-22 11:19:24 UTC
If AllowRenewalIfOtherItemsAvailable is enabled, Koha checks to make sure all other holds are fillable before renewing. It doesn't make sense to look at frozen holds for this reason, as they are by definition, unfillable.
Comment 1 Kyle M Hall (khall) 2022-08-22 11:22:24 UTC
Created attachment 139592 [details] [review]
Bug 31436: AllowRenewalIfOtherItemsAvailable should not take suspended holds into account

If AllowRenewalIfOtherItemsAvailable is enabled, Koha checks to make sure all other holds are fillable before renewing.
It doesn't make sense to look at suspended holds for this reason, as they are by definition, unfillable.
Comment 2 Joonas Kylmälä 2022-08-28 15:05:08 UTC
The bug 31112, dependency for this bug already fixed this issue. Closing.