Bug 31439

Summary: Item count bullet (•) should be easier to style/remove
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: trivial    
Priority: P5 - low CC: gmcharlt, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Attachments: Bug 31439: Use pseudo element for bullet in results.tt
Bug 31439: Use pseudo element for bullet in results.tt
Bug 31439: Use pseudo element for bullet in results.tt

Description Lucas Gass (lukeg) 2022-08-22 16:12:12 UTC
The staff results page included a bullet (&bull;) that is hard to target. It should be either wrapped in a class or a CSS psuedo element to make it easier to style of remove.
Comment 1 Lucas Gass (lukeg) 2022-09-01 18:14:30 UTC
Created attachment 140058 [details] [review]
Bug 31439: Use pseudo element for bullet in results.tt

To test:
1. Apply patch and regenerate CSS. See: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
2. Go to the staff results page and inscept the result_item_details class.
3. It should contain a ::before pseudo element that is the bullet point.
4. This is easier to remove of alter with the following CSS in IntraNetUSerCSS:

.result_item_details::before {
	content: " " !important;
}
Comment 2 Owen Leonard 2022-09-02 12:32:53 UTC
Created attachment 140113 [details] [review]
Bug 31439: Use pseudo element for bullet in results.tt

To test:
1. Apply patch and regenerate CSS. See:
  https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
2. Go to the staff results page and inscept the result_item_details
   class.
3. It should contain a ::before pseudo element that is the bullet point.
4. This is easier to remove of alter with the following CSS in
   IntraNetUSerCSS:

.result_item_details::before {
	content: " " !important;
}

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize (ashimema) 2022-09-12 16:55:29 UTC
Created attachment 140484 [details] [review]
Bug 31439: Use pseudo element for bullet in results.tt

To test:
1. Apply patch and regenerate CSS. See:
  https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client
2. Go to the staff results page and inscept the result_item_details
   class.
3. It should contain a ::before pseudo element that is the bullet point.
4. This is easier to remove of alter with the following CSS in
   IntraNetUSerCSS:

.result_item_details::before {
	content: " " !important;
}

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2022-09-12 16:55:53 UTC
Perfec', Passing QA
Comment 5 Tomás Cohen Arazi (tcohen) 2022-09-12 18:37:13 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!