Summary: | Provide an option to skip the test for atomic updates | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Test Suite | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, kyle, matt.blenkinsop, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually.
In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d
|
Version(s) released in: |
23.05.00
|
Circulation function: | |||
Bug Depends on: | 31108 | ||
Bug Blocks: | |||
Attachments: |
Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages
Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages |
Description
Aleisha Amohia
2022-08-28 22:21:43 UTC
Created attachment 139934 [details] [review] Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT Created attachment 150036 [details] [review] Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT Signed-off-by: Mason James <mtj@kohaaloha.com> signing off, looks good to me :) Created attachment 150388 [details] [review] Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Enhancement - not backporting to 22.11.x Nothing to add to the manual. |