Summary: | Move ItemsDeniedRenewal checks from C4::Circulation to Koha::Item | ||
---|---|---|---|
Product: | Koha | Reporter: | Joonas Kylmälä <joonas.kylmala> |
Component: | Circulation | Assignee: | Joonas Kylmälä <joonas.kylmala> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Attachments: |
Bug 31485: Move _item_denied_renewal to Koha::Item
Bug 31485: Move _item_denied_renewal to Koha::Item Bug 31485: Move _item_denied_renewal to Koha::Item |
Description
Joonas Kylmälä
2022-08-29 18:44:29 UTC
Created attachment 139965 [details] [review] Bug 31485: Move _item_denied_renewal to Koha::Item The question whether item is denied renewal doesn't depend on circulation rules or the patron, it is only a property of the item and only changes to the item's attributes can cause the return value of the check to change, thus we should move this to be a method of Koha::Item. To test: 1) Run unit tests $ prove t/db_dependent/Circulation.t $ prove t/db_dependent/Koha/Item.t Created attachment 140506 [details] [review] Bug 31485: Move _item_denied_renewal to Koha::Item The question whether item is denied renewal doesn't depend on circulation rules or the patron, it is only a property of the item and only changes to the item's attributes can cause the return value of the check to change, thus we should move this to be a method of Koha::Item. To test: 1) Run unit tests $ prove t/db_dependent/Circulation.t $ prove t/db_dependent/Koha/Item.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 141533 [details] [review] Bug 31485: Move _item_denied_renewal to Koha::Item The question whether item is denied renewal doesn't depend on circulation rules or the patron, it is only a property of the item and only changes to the item's attributes can cause the return value of the check to change, thus we should move this to be a method of Koha::Item. To test: 1) Run unit tests $ prove t/db_dependent/Circulation.t $ prove t/db_dependent/Koha/Item.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |