| Summary: | Holds reminder cronjob should consider expiration date of holds, and not send notices if hold expired | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, gmcharlt, lucas, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.08, 21.11.15
|
|
| Circulation function: | |||
| Attachments: |
Bug 31540: Exclude expired holds from the reminder job
Bug 31540: Exclude expired holds from the reminder job Bug 31540: Exclude expired holds from the reminder job |
||
|
Description
Nick Clemens (kidclamp)
2022-09-08 20:04:04 UTC
Created attachment 140461 [details] [review] Bug 31540: Exclude expired holds from the reminder job Some libraries don't want to auto-cancel holds, but we should not remind a patron about a hold which has expired. To test: 1 - Place a hold for a patron 2 - Set it waiting 3 - Run the holds reminder script in the future perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v 4 - Note the holds would be reminded 5 - Set expirationdate for the hold less than today UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY); 6 - Run the remidner cron again 7 - No holds trigger! Created attachment 140605 [details] [review] Bug 31540: Exclude expired holds from the reminder job Some libraries don't want to auto-cancel holds, but we should not remind a patron about a hold which has expired. To test: 1 - Place a hold for a patron 2 - Set it waiting 3 - Run the holds reminder script in the future perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v 4 - Note the holds would be reminded 5 - Set expirationdate for the hold less than today UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY); 6 - Run the remidner cron again 7 - No holds trigger! Signed-off-by: David Nind <david@davidnind.com> Created attachment 141014 [details] [review] Bug 31540: Exclude expired holds from the reminder job Some libraries don't want to auto-cancel holds, but we should not remind a patron about a hold which has expired. To test: 1 - Place a hold for a patron 2 - Set it waiting 3 - Run the holds reminder script in the future perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v 4 - Note the holds would be reminded 5 - Set expirationdate for the hold less than today UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY); 6 - Run the remidner cron again 7 - No holds trigger! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nick, you'll have to send me cookies for the next time I have to fix your Assignee! Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.08 release applied to 21.11 for 21.11.15 Backported to 21.05.x for 21.05.22 Not releasing in 21.05.22 (In reply to wainuiwitikapark from comment #9) > Not releasing in 21.05.22 Reverted from 21.05 branch |