Summary: | Getting holds via REST API needs edit_borrowers permission | ||
---|---|---|---|
Product: | Koha | Reporter: | Johanna Räisä <johanna.raisa> |
Component: | REST API | Assignee: | Johanna Räisä <johanna.raisa> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | kyle, lucas, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 31555: change holds GET permission to place_holds
Bug 31555: change holds GET permission to place_holds Bug 31555: change holds GET permission to place_holds |
Description
Johanna Räisä
2022-09-13 12:07:41 UTC
Created attachment 140611 [details] [review] Bug 31555: change holds GET permission to place_holds This patch changes holds' GET REST API endpoint permission to place_holds to match with request.pl Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Created attachment 140630 [details] [review] Bug 31555: change holds GET permission to place_holds This patch changes holds' GET REST API endpoint permission to place_holds to match with request.pl Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> Created attachment 141503 [details] [review] Bug 31555: change holds GET permission to place_holds This patch changes holds' GET REST API endpoint permission to place_holds to match with request.pl Test plan: 1) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Our permissions need a revamp (i.e. we should have individual permissions for each hold action). Pushed to master for 22.11. Nice work everyone, thanks! |