Bug 31559

Summary: Staff results page doesn't always use up full available screen width
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: arthur.suzuki, lucas, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08, 21.11.15
Attachments: Bug 31559: Staff results page doesn't always use up full available screen width
Bug 31559: Staff results page doesn't always use up full available screen width
Bug 31559: Staff results page doesn't always use up full available screen width

Description Katrin Fischer 2022-09-14 07:48:41 UTC
If the titles of the records are quite short, the entries of the result page will "shrink" not using the full available width of the page.

For an example with the sample data: search for 'Henry'.
Comment 1 Owen Leonard 2022-09-26 14:16:16 UTC
Created attachment 140985 [details] [review]
Bug 31559: Staff results page doesn't always use up full available screen width

This patch adds an explicit "width: 100%" to tables which are contained
within a #searchresults <div>. The change affects staff interface
catalog search results and these other pages with the same markup:

- Advanced MARC editor search results
- Holds to pull
- Patron search results

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Test the catalog search results and other affected pages to confirm
  that the tables affected take up the full width of the page.
Comment 2 Lucas Gass 2022-09-26 21:14:33 UTC
Created attachment 141011 [details] [review]
Bug 31559: Staff results page doesn't always use up full available screen width

This patch adds an explicit "width: 100%" to tables which are contained
within a #searchresults <div>. The change affects staff interface
catalog search results and these other pages with the same markup:

- Advanced MARC editor search results
- Holds to pull
- Patron search results

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Test the catalog search results and other affected pages to confirm
  that the tables affected take up the full width of the page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2022-10-01 19:23:25 UTC
Created attachment 141180 [details] [review]
Bug 31559: Staff results page doesn't always use up full available screen width

This patch adds an explicit "width: 100%" to tables which are contained
within a #searchresults <div>. The change affects staff interface
catalog search results and these other pages with the same markup:

- Advanced MARC editor search results
- Holds to pull
- Patron search results

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Test the catalog search results and other affected pages to confirm
  that the tables affected take up the full width of the page.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2022-10-03 15:42:19 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 5 Lucas Gass 2022-12-05 16:17:51 UTC
Backported to 22.05.x for upcoming 22.05.08 release
Comment 6 Arthur Suzuki 2022-12-14 11:55:04 UTC
applied to 21.11 for 21.11.15
Comment 7 wainuiwitikapark 2022-12-20 01:43:48 UTC
Backported to 21.05.x for 21.05.22
Comment 8 wainuiwitikapark 2022-12-23 00:23:35 UTC
Not released in 21.05.22
Comment 9 wainuiwitikapark 2023-03-15 00:41:33 UTC
(In reply to wainuiwitikapark from comment #8)
> Not released in 21.05.22

Reverted from 21.05 branch