Summary: | Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Hold requests | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arthur.suzuki, gmcharlt, jonathan.druart, lucas, martin.renvoize, rickard.lindfors, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31576 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.08, 21.11.15
|
|
Circulation function: | |||
Attachments: |
Bug 31575 - Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed
Bug 31575 - Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed Bug 31575: Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed |
Description
Kyle M Hall (khall)
2022-09-16 14:42:13 UTC
Created attachment 140710 [details] [review] Bug 31575 - Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign 7) Apply this patch 8) Restart all the things! 9) Reload the page, you should now see the warning icons! Created attachment 140737 [details] [review] Bug 31575 - Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign 7) Apply this patch 8) Restart all the things! 9) Reload the page, you should now see the warning icons! Signed-off-by: David Nind <david@davidnind.com> Created attachment 141489 [details] [review] Bug 31575: Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign 7) Apply this patch 8) Restart all the things! 9) Reload the page, you should now see the warning icons! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Working as expected now.. another one where perhaps moving things up a level would mean we had unit tests to prevent such a regression.. but nothing to prevent a QA pass here. Passed. Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.08 applied to 21.11 for 21.11.15 Not backported to 21.05.x *** Bug 26841 has been marked as a duplicate of this bug. *** I have been git bisect a selenium failure on 21.11.x STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 1693):1 in Selenium::Remote::Driver::__ANON__ (eval 1695):2 in Selenium::Remote::Driver::__ANON__ /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:1335 in Selenium::Remote::Driver::_execute_command /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:1335 in (eval) t/db_dependent/selenium/basic_workflow.t:263 in Selenium::Remote::Driver::find_element Error while executing command: unexpected alert open: Dismissed user prompt dialog: And found this commit 7a88155fe13c3a4f71f1a8d09b170738e7d8cbb8 is the first bad commit It's crazy that the failure has been ignored for so long... |