Description
Mason James
2022-09-20 16:22:23 UTC
Created attachment 140794 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (master) Created attachment 140801 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) Created attachment 140802 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (21.11) Created attachment 140803 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (21.05) CCing Arthur, I guess you meant to CC all RMaints. How to test? Idea: - for each branch, apply - push - wait for new container images to be built with this, ignore the automated batch of the CI run, it will be done on images out of date regarding this patch. See https://wiki.koha-community.org/wiki/Release_maintenance#Backporting_a_patch_with_a_new_perl_dependency - Rerun a bunch of builds manually - confirm they pass (In reply to Victor Grousset/tuxayo from comment #5) > CCing Arthur, I guess you meant to CC all RMaints. > > How to test? Idea: > - for each branch, apply > - push > - wait for new container images to be built with this, ignore the automated > batch of the CI run, it will be done on images out of date regarding this > patch. > See > https://wiki.koha-community.org/wiki/ > Release_maintenance#Backporting_a_patch_with_a_new_perl_dependency > - Rerun a bunch of builds manually > - confirm they pass to test: 1/ apply patch 2/ check 'modules' tab of about.pl page, all module versions should be white No need for anything related to docker images? Ok, that's even easier. For 21.05.x I had: JSON::Validator (3.14) 3.14 Mojolicious::Plugin::OpenAPI (2.16) 2.16 and everything white except Locale::XGettext::TT2 Now I have JSON::Validator (3.14 - 3.99) 3.14 Mojolicious::Plugin::OpenAPI (2.16 - 2.99) 2.16 Is that was is expected? I think there is a mistake in the patches for master and 22.05 - the version number for JSON:Validator has a comma in it instead of a full stop: requires 'JSON::Validator', '5,08'; master and 22.05 show in orange and as module upgrade needed for JSON::Validator (08) 5.08. JSON::Validator - 21.11: >=3.14, <=3.99 - OK, installed version shows as 3.14 - 21.05: >=3.14, <=3.99 - OK, installed version shows as 3.14 Mojolicious::Plugin::OpenAPI - master: 5.05 OK - 22.05: 5.05 OK - 21.11: >=2.16, <=2.99 - OK, installed version shows as 2.16 - 21.05: >=2.16, <=2.99 - OK, installed version shows as 2.16 The rough process I used for testing used with KTD (probably easier ways to do this) - repeat for all versions being updated (master to 21.05): Local git repository - check out the version of Koha being tested, for example: git checkout 22.05.x - create a branch: git checkout -B bz31588 KTD: - update .env so that KOHA_IMAGE reflects the version of Koha and patch being tested - start up KTD (images download) - apply the patch for the version of Koha being tested - check About Koha > Perl modules: module versions should reflect the patch and no warnings or errors, such as being highlighted in orange (module upgrade needed) - revert back to master (kshell, cd koha, git checkout [version being tested, e.g. 21.05.x], git branch -D bz31588, git reset --hard origin/[version being tested, e.g. 21.05.x], git checkout master, git branch -D [version being tested, e.g. 21.05.x], git reset --hard origin/master) (probably easier ways tod o this?) - shutdown KTD Created attachment 141558 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James <mtj@kohaaloha.com> Created attachment 141559 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) (In reply to David Nind from comment #8) > I think there is a mistake in the patches for master and 22.05 - the version > number for JSON:Validator has a comma in it instead of a full stop: > requires 'JSON::Validator', '5,08'; > oops, ive fixed the comma ',' :) Created attachment 141561 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 141562 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) Signed-off-by: David Nind <david@davidnind.com> Created attachment 141563 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (21.11) Signed-off-by: David Nind <david@davidnind.com> Created attachment 141564 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (21.05) Signed-off-by: David Nind <david@davidnind.com> Have signed off. See comment #8 for how I tested - hope this is sufficient. Note that for Koha 21.05, Locale::XGettext::TT2 (0.7) shows as orange and Not Installed. David (In reply to David Nind from comment #16) > Have signed off. > > See comment #8 for how I tested - hope this is sufficient. > > Note that for Koha 21.05, Locale::XGettext::TT2 (0.7) shows as orange and > Not Installed. this will be fixed when bug 30252 is pushed to 21.05 This should probably be renamed to "Update cpanfile for new Mojolicious::Plugin::OpenAPI versions" no? We're still using OpenAPI version 2 (and it looks like the new versions don't fully support OpenAPI version 3 anyway). Created attachment 142364 [details] [review] Bug 31588 - Update cpanfile for new OpenAPI versions (master) Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.08 applied to 21.11 for 21.11.15 Not backported to 21.05.x |