Summary: | Replace Try::Tiny with something faster | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Architecture, internals, and plumbing | Assignee: | Bugs List <koha-bugs> |
Status: | NEW --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, kyle, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: |
Description
Kyle M Hall (khall)
2022-09-22 13:47:25 UTC
Well, this is interesting! Thanks Kyle On https://metacpan.org/pod/Syntax::Keyword::Try, the author points out that try/catch/finally was (finally) added to Perl 5.34 (released May 20 2021) and that Feature::Compat::Try should be used for new code It looks like Perl 5.34 is used in Ubuntu from 22.04 onward. In Debian, it's in bookworm/testing. Although it looks like the "try" feature is still marked as experimental: https://perldoc.perl.org/feature#The-'try'-feature. Looks like Syntax::Keyword::Try has some issues with Perl older than 5.24 (https://metacpan.org/pod/Syntax::Keyword::Try#$@-is-not-local'ised-by-try-do-before-perl-5.24) but I don't think we support any OS that has a Perl that old. Syntax::Keyword::Try/Feature::Compat::Try sound pretty interesting. |