Summary: | REST API: Add endpoint for generated covers | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Derscheid <paul.derscheid> |
Component: | REST API | Assignee: | Paul Derscheid <paul.derscheid> |
Status: | ASSIGNED --- | QA Contact: | |
Severity: | new feature | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Bug 31624: REST API: Add endpoint for generated covers |
Description
Paul Derscheid
2022-09-26 13:34:01 UTC
Created attachment 144726 [details] [review] Bug 31624: REST API: Add endpoint for generated covers This commit contains the main changes for the endpoint and the controller for the image generation. To test this, if you don't have a very elaborate setup: 1. Apply the patch 2. Request the endpoint, for example using: http://localhost:8080/api/v1/public/biblios/1/default_cover 3. Now you could use this JS in your console to get an unescaped version of the JSON response const response = await fetch('http://localhost:8080/api/v1/public/biblios/1/default_cover'); const result = await response.json(); console.log(result); 4. Copy the response and check whether it actually is a valid base64 encoded image. For example using this tool: https://base64.guru/converter/decode/file 5. Give me your thoughts on this patch I'm still in the process of using unit tests and hunting bugs, so it's now ready for a sign-off but I thought I'd already show it to whoever is interested. The preliminary test plan assumes ktd, btw. I made some typos. The patch is not ready for a sign-off (not 'now' ready). And of course I'm in the process of writing unit tests, not using them. [U+1F62C] See #c1 for reference. |