Summary: | Empty title for current result in OPAC results browser's tooltip on paging | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | lucas, pablo.bianchi |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.11.00
|
Circulation function: | |
Attachments: |
Bug 31635: Fix output of current title in OPAC browse results
Bug 31635: Fix output of current title in OPAC browse results Bug 31635: Fix output of current title in OPAC browse results |
Description
Caroline Cyr La Rose
2022-09-27 15:46:24 UTC
I think it has to do with the fact that the other results are "listitems" of "listResults" whereas the current result is not one of those listitems. I had a similar problem when trying to work out how to solve bug 31634, I was able to add the part_number and part_name for the current result, but I had to do some acrobatics to add them for the other results. Created attachment 141301 [details] [review] Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. Created attachment 141332 [details] [review] Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 141532 [details] [review] Bug 31635: Fix output of current title in OPAC browse results This patch makes a correction to the output of OPAC browse results. In the numbered result navigation links, a title tag on each navigation link should contain the title of the record. The link for the current title didn't include the title information in the title tag because it used the wrong template variables. To test, apply the patch and make sure OpacBrowseResults is enabled. - In OPAC, perform a search that will return multiple results. - View one of the results. - In the right-hand sidebar, click "Browse results." - In the list of numbered links at the top of the panel, hover your mouse over each link. They should each display a tooltip with "View record [title]" - Confirm that the current title in the list includes the correct tooltip. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Will be backported to 22.05? |