Bug 31643

Summary:	Link authorities automatically requires ALL cataloging and authorities permissions
Product:	Koha	Reporter:	Donna <bwsdonna>
Component:	Cataloging	Assignee:	Nick Clemens (kidclamp) <nick>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	normal
Priority:	P5 - low	CC:	arthur.suzuki, catrina, hebah, lucas, m.de.rooy, nick, wainuiwitikapark
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00, 22.05.8, 21.11.15
Circulation function:
Attachments:	Bug 31643: Require only edit_catalogue, not full cataloging Bug 31643: Require only edit_catalogue, not full cataloging Bug 31643: Require only edit_catalogue, not full cataloging

Description Donna 2022-09-28 18:43:46 UTC

The functionality in cataloging Link Authorities Automatically requires top level cataloging permissions.  This is a problem as if you are using Limit item modification to subfields defined in the SubfieldsToAllowForRestrictedEditing preference (please note that edit_item is still required) (edit_items_restricted), you would need that permission enabled which will cause top level catalogers from being able to edit all things.

This functionality should only require edit_catalogue.

Comment 1 Nick Clemens (kidclamp) 2022-09-28 19:01:51 UTC

Created attachment 141067 [details] [review]
Bug 31643: Require only edit_catalogue, not full cataloging

To test:
1 - Grant a patron: catalogue, edit_catalogue, and editauthorities permissions
2 - Log in to staff client
3 - Browse to: http://localhost:8081/cgi-bin/koha/svc/cataloguing/automatic_linker.pl
4 - UNAUTHORIZED
5 - Apply patch, restart all
6 - Log in and go to link again
7 - status "OK"

Comment 2 ByWater Sandboxes 2022-09-30 14:55:23 UTC

Created attachment 141170 [details] [review]
Bug 31643: Require only edit_catalogue, not full cataloging

To test:
1 - Grant a patron: catalogue, edit_catalogue, and editauthorities permissions
2 - Log in to staff client
3 - Browse to: http://localhost:8081/cgi-bin/koha/svc/cataloguing/automatic_linker.pl
4 - UNAUTHORIZED
5 - Apply patch, restart all
6 - Log in and go to link again
7 - status "OK"

Signed-off-by: Catrina <catrina@bywatersolutions.com>

Comment 3 Catrina Berka 2022-09-30 14:56:06 UTC

Works as expected. Allows for Linking authorities in record editing with those staff permissions set.

Comment 4 Katrin Fischer 2022-10-01 23:05:11 UTC

Created attachment 141200 [details] [review]
Bug 31643: Require only edit_catalogue, not full cataloging

To test:
1 - Grant a patron: catalogue, edit_catalogue, and editauthorities permissions
2 - Log in to staff client
3 - Browse to: http://localhost:8081/cgi-bin/koha/svc/cataloguing/automatic_linker.pl
4 - UNAUTHORIZED
5 - Apply patch, restart all
6 - Log in and go to link again
7 - status "OK"

Signed-off-by: Catrina <catrina@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2022-10-03 16:53:36 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 6 hebah 2022-11-17 18:25:14 UTC

Any chance of backporting this to 22.05?

Comment 7 Lucas Gass (lukeg) 2022-12-05 16:37:57 UTC

Backported to 22.05.x for upcoming 22.05.08 release

Comment 8 Arthur Suzuki 2022-12-14 11:59:57 UTC

applied to 21.11.x for 21.11.15

Comment 9 Wainui Witika-Park 2022-12-20 01:49:39 UTC

Backported to 21.05.x for 21.05.22

Comment 10 Wainui Witika-Park 2022-12-23 00:24:06 UTC

Not released in 21.05.22

Comment 11 Wainui Witika-Park 2023-03-15 00:40:46 UTC

(In reply to wainuiwitikapark from comment #10)
> Not released in 21.05.22

Reverted from 21.05 branch