Description
Fridolin Somers
2022-09-29 06:31:50 UTC
Maybe this comes from Bug 18262 that removed GetBiblioData() Created attachment 141076 [details] [review] Bug 31649: Add unit tests Creates new test file GetBasketGroupAsCSV.t Test with : prove t/db_dependent/Acquisition/GetBasketAsCSV.t prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t Created attachment 141077 [details] [review] Bug 31649: Fix acquisition basket CSV export if biblio does not exist Created attachment 141078 [details] [review] Bug 31649: Fix acquisition basket group CSV export if biblio does not exist Created attachment 141084 [details] [review] Bug 31649: Add unit tests Creates new test file GetBasketGroupAsCSV.t Test with : prove t/db_dependent/Acquisition/GetBasketAsCSV.t prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t Signed-off-by: David Nind <david@davidnind.com> Created attachment 141085 [details] [review] Bug 31649: Fix acquisition basket CSV export if biblio does not exist Signed-off-by: David Nind <david@davidnind.com> Created attachment 141086 [details] [review] Bug 31649: Fix acquisition basket group CSV export if biblio does not exist Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Add two items to a basket. 2. Deleted the items and record for one of the items. 3. Try to Export as CSV (above the basket title, not the datatable export options) - get error as described. 4. Close basket, add to a group, test Export as CSV - get erorr. 5. Repeat steps after patch applied - no error! 6. Tests pass. Created attachment 141548 [details] [review] Bug 31649: Add unit tests Creates new test file GetBasketGroupAsCSV.t Test with : prove t/db_dependent/Acquisition/GetBasketAsCSV.t prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 141549 [details] [review] Bug 31649: Fix acquisition basket CSV export if biblio does not exist Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 141550 [details] [review] Bug 31649: Fix acquisition basket group CSV export if biblio does not exist Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This is a good immediate fix to keep libraries going, but ultimately we need to fix the 'deleted records and orders' issue properly. Libraries need to be able to account on acq and that includes being able to tell how money was spent at all times - even after they have been deleted/withdrawn from the library's holdings. Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.08 applied to 21.11 for 21.11.15. I didn't applied the last patch though, because it modifies a file that is not even present in 21.11. oups, actually applied all patches fine. the patch not applied is from another bug. Not backported to 21.05.x |