Bug 31667

Summary:	Merge 'tip' and 'hint' classes
Product:	Koha	Reporter:	Fridolin Somers <fridolin.somers>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	RESOLVED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	minor
Priority:	P5 - low
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.11.00,23.05.03,22.11.09
Circulation function:
Attachments:	Bug 31667: Merge 'tip' and 'hint' classes Bug 31667: Merge 'tip' and 'hint' classes Bug 31667: Merge 'tip' and 'hint' classes Bug 31667: Merge 'tip' and 'hint' classes

Description Fridolin Somers 2022-10-01 04:36:09 UTC

'tip' and 'hint' are classes for a CSS with grey color.

Looks like 'hint' is way more used that 'tip' (mainly used for header search boxes).
I think we should replace 'tip' with 'hint' to have only one class for this usage.
And maybe add a coding guide line.

Comment 1 Fridolin Somers 2022-10-01 04:41:40 UTC

 > git grep -e 'class="hint[ "]' -- koha-tmpl/ | wc -l
343
 > git grep -e 'class="tip[ "]' -- koha-tmpl/ | wc -l
42

They may be few places where this class is not the first.
But hint is clearly the boss ;)

Comment 2 Owen Leonard 2023-07-25 15:51:09 UTC

Created attachment 153888 [details] [review]
Bug 31667: Merge 'tip' and 'hint' classes

This patch corrects a few instances of the use of the "tip" class and
replaces them with "hint." The patch also removes the class from the
staff interface CSS.

To test, apply the patch and rebuild the staff interface CSS.

- View a patron account and click the "Routing lists" link in the
  left-hand sidebar.
  - On the subscription routing lists page the "Search subscriptions"
    page label should look correct.
- Go to Reports -> Catalog by item type.
  - The "Select none..." hint should be styled correctly.
- The third instance, in the installer, is only visible if you try to
  install Koha using a MySQL user who doesn't have the correct
  privileges, so may be too much trouble to really test. A check of the
  patch should be adequate.

Comment 3 Fridolin Somers 2023-07-27 21:47:54 UTC

There is another CSS rule in staff-global.scss :

label {
...
    &.tip {
        display: block;
        margin: .5em 0;
    }

Comment 4 Owen Leonard 2023-08-03 18:41:16 UTC

Created attachment 154233 [details] [review]
Bug 31667: Merge 'tip' and 'hint' classes

This patch corrects a few instances of the use of the "tip" class and
replaces them with "hint." The patch also removes the class from the
staff interface CSS.

To test, apply the patch and rebuild the staff interface CSS.

- View a patron account and click the "Routing lists" link in the
  left-hand sidebar.
  - On the subscription routing lists page the "Search subscriptions"
    page label should look correct.
- Go to Reports -> Catalog by item type.
  - The "Select none..." hint should be styled correctly.
- The third instance, in the installer, is only visible if you try to
  install Koha using a MySQL user who doesn't have the correct
  privileges, so may be too much trouble to really test. A check of the
  patch should be adequate.

Comment 5 Fridolin Somers 2023-08-04 07:00:40 UTC

Created attachment 154236 [details] [review]
Bug 31667: Merge 'tip' and 'hint' classes

This patch corrects a few instances of the use of the "tip" class and
replaces them with "hint." The patch also removes the class from the
staff interface CSS.

To test, apply the patch and rebuild the staff interface CSS.

- View a patron account and click the "Routing lists" link in the
  left-hand sidebar.
  - On the subscription routing lists page the "Search subscriptions"
    page label should look correct.
- Go to Reports -> Catalog by item type.
  - The "Select none..." hint should be styled correctly.
- The third instance, in the installer, is only visible if you try to
  install Koha using a MySQL user who doesn't have the correct
  privileges, so may be too much trouble to really test. A check of the
  patch should be adequate.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Comment 6 Fridolin Somers 2023-08-04 07:01:15 UTC

Thanks a lot Owen for the additional work ;)

Comment 7 Katrin Fischer 2023-08-04 12:31:41 UTC

Created attachment 154261 [details] [review]
Bug 31667: Merge 'tip' and 'hint' classes

This patch corrects a few instances of the use of the "tip" class and
replaces them with "hint." The patch also removes the class from the
staff interface CSS.

To test, apply the patch and rebuild the staff interface CSS.

- View a patron account and click the "Routing lists" link in the
  left-hand sidebar.
  - On the subscription routing lists page the "Search subscriptions"
    page label should look correct.
- Go to Reports -> Catalog by item type.
  - The "Select none..." hint should be styled correctly.
- The third instance, in the installer, is only visible if you try to
  install Koha using a MySQL user who doesn't have the correct
  privileges, so may be too much trouble to really test. A check of the
  patch should be adequate.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Comment 8 Tomás Cohen Arazi (tcohen) 2023-08-15 12:20:03 UTC

Pushed to master for 23.11.

Nice work everyone, thanks!

Comment 9 Fridolin Somers 2023-08-17 20:20:40 UTC

Pushed to 23.05.x for 23.05.03

Comment 10 Pedro Amorim 2023-08-18 13:45:55 UTC

Nice work everyone!

Pushed to 22.11.x for next release