Summary: | Avoid displaying nothing in facet | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Searching | Assignee: | Alexis Ripetti <alexis.ripetti> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29561 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | Bug 31668: Avoid displaying nothing in facet |
Description
Nick Clemens (kidclamp)
2022-10-03 10:37:22 UTC
Created attachment 141245 [details] [review] Bug 31668: Avoid displaying nothing in facet This patch displays 'No information provided' if a facet value/description cannot be found, rather than displaying an empty/hidden facet Test plan: 1) Do a search, like 'a' 2) Look in the bottom of the sidebar on the left and see that there is an empty language 3) Apply patch 4) Update database 5) Do the same research 6) See that there is now "No information provided" Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> At the moment I believe this is not fully functional. With this patch, we display a text, the count displays correctly, but when clicking on the link, we find 'all', as the empty search with ln: doesn't work right. There are a lot of reasons why a library might not have added language information, like dealing with old/migrated data. For the moment I prefer Nick's solution on bug 29561 that removes those empty facets from display - so they won't appear at all if empty. If I misunderstood something, please let me know! |