Bug 31690

Summary:	Add see from tracings in See-from index (Elasticsearch, MARC21)
Product:	Koha	Reporter:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Component:	Searching - Elasticsearch	Assignee:	Caroline Cyr La Rose <caroline.cyr-la-rose>
Status:	CLOSED FIXED	QA Contact:	Kyle M Hall (khall) <kyle>
Severity:	enhancement
Priority:	P5 - low	CC:	david, kyle, lucas, tomascohen
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31687 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31689 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31691
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:	This enhancement adds fields 450, 451, and 455 to the See-from index for MARC21. Previously, only 400, 410, 411, 430, 447, 448, and 462 were indexed.	Version(s) released in:	22.11.00
Circulation function:
Attachments:	Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21) Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

Description Caroline Cyr La Rose 2022-10-05 15:35:57 UTC

Some see from tracings are indexed in See-from, but not all.

Currently indexed are 400, 410, 411, 430, 440, 441, 444, 447, 448, and 462. Missing are 450, 451, and 455.

Also, 440, 441, and 444 are not valid MARC fields. But that is something for another bug...

I'm not sure exactly where this index is used, but I figure it's best that the index be complete rather than indexing only some types of authorities.

Comment 1 Caroline Cyr La Rose 2022-10-05 15:38:45 UTC

Created attachment 141386 [details] [review]
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

This patch adds the following fields to the See-from index

- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Comment 2 Caroline Cyr La Rose 2022-10-05 15:41:13 UTC

Sorry, I'm not sure where this index is used so I don't know how to test...

Comment 3 David Nind 2022-10-10 19:26:08 UTC

Created attachment 141585 [details] [review]
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

This patch adds the following fields to the See-from index

- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Signed-off-by: David Nind <david@davidnind.com>

Comment 4 David Nind 2022-10-10 19:28:04 UTC

"Tested" by comparing the list of fields added with the Library of Congress definitions[1] to make sure they exist.

[1] https://www.loc.gov/marc/authority/ad4xx.html

Comment 5 Kyle M Hall (khall) 2022-10-21 11:34:19 UTC

Created attachment 142334 [details] [review]
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

This patch adds the following fields to the See-from index

- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Comment 6 Tomás Cohen Arazi (tcohen) 2022-10-24 14:47:33 UTC

Please rebase

Comment 7 Caroline Cyr La Rose 2022-10-24 15:01:29 UTC

Created attachment 142518 [details] [review]
Bug 31690: Add see from tracings in See-from index (Elasticsearch, MARC21)

This patch adds the following fields to the See-from index

- 450(abvxyz)
- 451(avxyz)
- 455(avxyz)

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Comment 8 Caroline Cyr La Rose 2022-10-24 15:02:29 UTC

I rebased it. I wasn't sure which status to put it in after

Comment 9 Katrin Fischer 2022-10-24 16:36:14 UTC

If you feel it's not a totally different patch/are confident it's still working, you can go back to PQA straight away :)

Comment 10 Tomás Cohen Arazi (tcohen) 2022-10-24 17:41:42 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!