| Summary: | Value builder unimarc_field_010.pl should also use 214$c | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Cataloging | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | amaury.gau, david, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32822 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Bug 31717: Value builder unimarc_field_010.pl also use 214$c | ||
|
Description
Fridolin Somers
2022-10-07 20:19:12 UTC
Created attachment 141523 [details] [review] Bug 31717: Value builder unimarc_field_010.pl also use 214$c Value builder unimarc_field_010.pl tries to find publisher from ISBN in order to fill 210$c. Since there is now 214$c for publisher this value builder should be adapted. Test plan : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode, For example 9782070612369 and Gallimard 2) Use value builder unimarc_field_010.pl on 010$a 3) Create a new record 4) Enter 9782070612369 in 010$a 5) Click on value builder icon on this subfield 6) Check you see 'Gallimard' in 214$c I had a go at testing this, but couldn't get it to work. I'm not sure what I'm doing wrong... I'm sure it is something basic! What I did: 1. Before applying the patch, I checked the current behaviour: . Added unimarc_field_010.pl to 010$a . Created a new record . Entered 9782070612369 in 010$a . Checked 210$c - automatically populated with Gallimard 2. After applying the patch (and flush_memcached, restart_all, fresh browser): . Created a new record . Entered 9782070612369 in 010$a . Checked 210$c - still automatically populated with Gallimard . Checked 214$c - not automatically populated with Gallimard I'm not even there at testing. I did : 1) Choose an existing record with an ISBN and a published in biblioitems.publishercode. I used2211015344 and Ecole des loisirs 2)I don't see the value builder unimarc_field_010.pl on 010$a. I'm not sure about the process here. (In reply to Amaury GAU from comment #3) > I'm not even there at testing. > > > I did : > > 1) Choose an existing record with an ISBN and a published in > biblioitems.publishercode. I used2211015344 and Ecole des loisirs > > 2)I don't see the value builder unimarc_field_010.pl on 010$a. > > > I'm not sure about the process here. Hi, You need to test on a UNIMARC database. Configure framework on 010$a if needed. (In reply to Fridolin Somers from comment #4) > Hi, > > You need to test on a UNIMARC database. > Configure framework on 010$a if needed. Hi, 1) I went to Koha Adminstration/Catalog/MARC bibliographic framework. There, in all the frameworks: Actions > Marc structure > 010 Actions > Edit subfield > a > plugin > unimarc_field_010.pl > Save 2) In cataloging, I added a new record in agreement with the framework I installed the plugin in. 3) I found a tag editor on 10$a, but it was not clickable. 4) Entered the ISBN 2211015344, 210$c automatically filled but 214$c was not. Did I miss something else maybe ? Ah it is a Javascript change, try refreshing cache after applying patch : Ctrl + F5 Good news, the patch still applies! Not so good news, as in comment #2 and comment #5 it still doesn't work as expected. After applying the patch, everything was restarted (flush_memcached) and a fresh browser (with cache cleared) was used. |