Bug 31722

Summary:	Don't show EDIFACT note on basket group page if EDIFACT is turned off
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Acquisitions	Assignee:	Philip Orr <philip.orr>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	minor
Priority:	P5 - low	CC:	Laura.escamilla, lucas, martin.renvoize, philip.orr
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.05
Circulation function:
Attachments:	Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on

Description Katrin Fischer 2022-10-08 12:52:51 UTC

We now have the system preference EDIFACT to turn/on off the EDI functionality. 

If a vendor has no EDI information linked to it, we currently show this note on the basket group page:

No EDIFACT configuration for My Vendor

The visibilitey/display of this note should depend on the preference setting.

Comment 1 Philip Orr 2023-03-30 10:26:01 UTC

Created attachment 148972 [details] [review]
Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on

This patch makes a small change to the display of the note
"No EDIFACT configuration for..." on the basket group page to
only display if the system preference EDIFACT is set to "Enable".

To Test:
1. apply patch
2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor
3. create a basket group (doesn't have to have any baskets, an empty one will do)
4. close the basket group
5. set system preference "EDIFACT" to "Enable"
6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have
   an EDI account configured
7. navigate to your vendor's closed basket groups
   over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed"
8. you should see a message "No EDIFACT configuration for (name of vendor)" in the
   Action column
9. set system preference "EDIFACT" to "Disable"
10. go back to your vendor's closed basket groups
11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)"

Comment 2 ByWater Sandboxes 2023-03-30 12:31:39 UTC

Created attachment 148976 [details] [review]
Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on

This patch makes a small change to the display of the note
"No EDIFACT configuration for..." on the basket group page to
only display if the system preference EDIFACT is set to "Enable".

To Test:
1. apply patch
2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor
3. create a basket group (doesn't have to have any baskets, an empty one will do)
4. close the basket group
5. set system preference "EDIFACT" to "Enable"
6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have
   an EDI account configured
7. navigate to your vendor's closed basket groups
   over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed"
8. you should see a message "No EDIFACT configuration for (name of vendor)" in the
   Action column
9. set system preference "EDIFACT" to "Disable"
10. go back to your vendor's closed basket groups
11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)"

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>

Comment 3 Katrin Fischer 2023-04-09 11:31:54 UTC

Created attachment 149354 [details] [review]
Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on

This patch makes a small change to the display of the note
"No EDIFACT configuration for..." on the basket group page to
only display if the system preference EDIFACT is set to "Enable".

To Test:
1. apply patch
2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor
3. create a basket group (doesn't have to have any baskets, an empty one will do)
4. close the basket group
5. set system preference "EDIFACT" to "Enable"
6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have
   an EDI account configured
7. navigate to your vendor's closed basket groups
   over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed"
8. you should see a message "No EDIFACT configuration for (name of vendor)" in the
   Action column
9. set system preference "EDIFACT" to "Disable"
10. go back to your vendor's closed basket groups
11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)"

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2023-04-14 14:19:42 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 5 Matt Blenkinsop 2023-04-18 12:11:50 UTC

Nice work everyone!

Pushed to stable for 22.11.x

Comment 6 Lucas Gass (lukeg) 2023-05-05 22:21:23 UTC

Doesn't apply clean to 22.05.x, no backport.