Summary: | MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page | ||
---|---|---|---|
Product: | Koha | Reporter: | David Nind <david> |
Component: | Cataloging | Assignee: | David Nind <david> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the breadcrumb when deleting a subfield for a framework. An 'i' was incorrectly added to the end of the breadcrumb on the deletion confirmation page, for example: ... > Confirm deletion of subfield bi
|
Version(s) released in: |
22.11.00
|
Circulation function: | |||
Bug Depends on: | 27846 | ||
Bug Blocks: | |||
Attachments: |
Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield
Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield |
Description
David Nind
2022-10-09 21:37:14 UTC
Created attachment 141560 [details] [review] Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Looks like a VIM residue ;) (In reply to Fridolin Somers from comment #2) > Looks like a VIM residue ;) That was my thought as well. The other alternative was that it should be a ? to match the dialogue box text. But I think it makes sense not to have the question mark. Created attachment 141591 [details] [review] Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 141592 [details] [review] Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Thanks Fridolin for signing off! Created attachment 141854 [details] [review] Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Vim users.... haha Pushed to master for 22.11. Nice work everyone, thanks! |