Bug 31761

Summary:	Toolbar clarity and consistency
Product:	Koha	Reporter:	Martin Renvoize (ashimema) <martin.renvoize>
Component:	Staff interface	Assignee:	Bugs List <koha-bugs>
Status:	In Discussion ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, jonathan.druart, nick, oleonard, pedro.amorim, sally.healey
Version:	unspecified
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	30952
Bug Blocks:

Description Martin Renvoize (ashimema) 2022-10-13 11:04:41 UTC

Our toolbars are widely inconsistent across the staff client and with bug 30952 they became much less obvious as a 'call to action' to the end user.

See https://github.com/jajm/koha-staff-interface-redesign/issues/26 for some discussion around this.

I think we can still improve here.. Consistency wise and also overall contrast/clarity improvements.

Comment 1 Martin Renvoize (ashimema) 2023-06-07 11:15:31 UTC

See also: https://wiki.koha-community.org/wiki/Style_Guide#Toolbars_.28DRAFT.29

Comment 2 Pedro Amorim 2023-06-07 11:35:06 UTC

Visit /cgi-bin/koha/catalogue/itemsearch.pl
Check "Go to advanced search" button style

Visit /cgi-bin/koha/catalogue/search.pl
Check "Go to item search" link style

These 2 things should match.

Additionally, in /cgi-bin/koha/catalogue/search.pl "More options" and "Clear fields" are actions that affect the current page, whilst "Go to item search" takes the user to a different page.
The "go to" in the label may be considered a good enough hint, but bug 33190 introduces a new optional link to this toolbar, that also navigates to a different page, and to keep adding "go to" to these links does not seem like a sustainable option.
I agree with Martin's comment in bug 33190 that we should find a way to further distinguish these actions in this toolbar.

-------

These docs are very good:
https://wiki.koha-community.org/wiki/Interface_patterns#Toolbar_buttons

But I think this specific case for advanced-search toolbar does not fit in any of the examples there.

Comment 3 Fridolin Somers 2023-08-31 18:18:41 UTC

Maybe we should first fix contrast on another bug report right ?

It is really hard to see the toolbar text grey on grey.

Comment 4 Pedro Amorim 2023-09-01 10:17:11 UTC

(In reply to Fridolin Somers from comment #3)
> Maybe we should first fix contrast on another bug report right ?
> 
> It is really hard to see the toolbar text grey on grey.

+1

Comment 5 Pedro Amorim 2023-09-05 11:19:01 UTC

(In reply to Fridolin Somers from comment #3)
> Maybe we should first fix contrast on another bug report right ?
> 
> It is really hard to see the toolbar text grey on grey.

What I think we really need is a template block for toolbar-button and a template block for toolbar-link. See bug 34707.
Thoughts?