| Summary: | Add 'page-section' to patron lists page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, gmcharlt, lucas, oleonard, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 30952 | ||
| Bug Blocks: | 31757 | ||
| Attachments: |
Bug 31763: Add 'page-section' to patron lists page
Bug 31763: Add 'page-section' to patron lists page Bug 31763: Add 'page-section' to patron lists page Bug 31763: Add 'page-section' to patron lists page |
||
|
Description
Martin Renvoize (ashimema)
2022-10-13 12:10:53 UTC
Created attachment 141835 [details] [review] Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a <fieldset> to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Created attachment 141840 [details] [review] Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a <fieldset> to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 141845 [details] [review] Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a <fieldset> to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> I hadn't refreshed the page - I now see it was already signed off! I notice that the auto complete for patron search when adding patrons to a list is not working (it wasn't working before the patch was applied). Should this be a separate bug? (In reply to David Nind from comment #4) > I hadn't refreshed the page - I now see it was already signed off! > > I notice that the auto complete for patron search when adding patrons to a > list is not working (it wasn't working before the patch was applied). > > Should this be a separate bug? Never hurts to have 2 sign-offs! I see there is a JS error on that page and that is likely why the auto complete function is broken: Uncaught TypeError: $(...).autocomplete(...).data(...) is undefined Let's file a separate bug for that. (In reply to Lucas Gass from comment #5) > Let's file a separate bug for that. Bug 31782 created for this. Created attachment 141865 [details] [review] Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a <fieldset> to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Looks good, thanks for the quick work. Passing QA.. Thanks for opening another bug regarding autocomplete.. that confused me for a moment too before I read your comments. Pushed to master for 22.11. Nice work everyone, thanks! |