Bug 31767

Summary:	Add 'page-section' to tags page
Product:	Koha	Reporter:	Martin Renvoize (ashimema) <martin.renvoize>
Component:	Staff interface	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt, koha-bugs, lucas, oleonard, testopia
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00
Circulation function:
Bug Depends on:	30952
Bug Blocks:	31757
Attachments:	Bug 31767: Add 'page-section' to tags page Bug 31767: Add 'page-section' to tags page Bug 31767: Add 'page-section' to tags page

Description Martin Renvoize (ashimema) 2022-10-13 12:21:19 UTC

We need the page-section div adding to the tags page to ensure proper contrast for even/odd rows on the tables.

Comment 1 Owen Leonard 2022-10-13 18:55:29 UTC

Created attachment 141838 [details] [review]
Bug 31767: Add 'page-section' to tags page

This patch updates tags templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Tags.

- Confirm that the content area of the page looks correct.
- Click one of the tag terms to view the list of titles tagged with that
  term. Confirm that this page looks correct too.

Comment 2 Lucas Gass (lukeg) 2022-10-13 20:11:13 UTC

Created attachment 141842 [details] [review]
Bug 31767: Add 'page-section' to tags page

This patch updates tags templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Tags.

- Confirm that the content area of the page looks correct.
- Click one of the tag terms to view the list of titles tagged with that
  term. Confirm that this page looks correct too.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Comment 3 Katrin Fischer 2022-10-15 08:30:49 UTC

Created attachment 141919 [details] [review]
Bug 31767: Add 'page-section' to tags page

This patch updates tags templates so that the main content of
the page is wrapped with a "page-section" div. This ensures that content
has sufficient contrast. See Bug 31757.

Note: This patch contains indentation changes, so use diff accordingly.

To test, apply the patch and go to Tools -> Tags.

- Confirm that the content area of the page looks correct.
- Click one of the tag terms to view the list of titles tagged with that
  term. Confirm that this page looks correct too.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2022-10-17 11:08:57 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!