Summary: | Add 'page-section' to manage MARC import page | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, koha-bugs, lucas, oleonard, testopia |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | 31757 | ||
Attachments: |
Bug 31773: Add page-section class to Manage staged MARC records page
Bug 31773: Add page-section class to Manage staged MARC records page Bug 31773: Add page-section class to Manage staged MARC records page |
Description
Martin Renvoize (ashimema)
2022-10-13 12:33:40 UTC
Created attachment 141843 [details] [review] Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. Created attachment 141846 [details] [review] Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. Signed-off-by: David Nind <david@davidnind.com> I think this changed a different page - adjusting description to manage marc import and refiled MARC modification templates as bug 31811. Created attachment 141918 [details] [review] Bug 31773: Add page-section class to Manage staged MARC records page To test: 1. Apply patch 2. Have some MARC records and stage them for import. It will be nessesary to add more than 1 3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added. Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> This does what it says, but also the table has a line on top of the header line, which is inconsistent with other pages... do we have a bug for those yet? I spotted a table inconsistency like that somewhere else yesterday.. can't for the life of me remember where. I didn't submit a big for it yet, got distracted, but we probably should report such bugs as and when we spot them.. I imagine it's yet another small inconsistency with our markup which should be fixed rather than further targeted class rules being added. (In reply to Martin Renvoize from comment #6) > I spotted a table inconsistency like that somewhere else yesterday.. can't > for the life of me remember where. I didn't submit a big for it yet, got > distracted, but we probably should report such bugs as and when we spot > them.. I imagine it's yet another small inconsistency with our markup which > should be fixed rather than further targeted class rules being added. I've created an omnibus with a first linked bug for this one: Bug 31833 - [Omnibus] Fix table inconsistencies Bug 31834 - Inconsistent table formatting for list of MARC imports Pushed to master for 22.11. Nice work everyone, thanks! |