Summary: | Add 'page-section' to Manage staged MARC records page | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize <martin.renvoize> |
Component: | Staff interface | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, katrin.fischer, koha-bugs, lucas, oleonard, testopia |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Bug Depends on: | 30952 | ||
Bug Blocks: | 31757 | ||
Attachments: |
Bug 31774: Add 'page-section' to list of imported records
Bug 31774: Add 'page-section' to list of imported records Bug 31774: Add 'page-section' to list of imported records Bug 31774: Add 'page-section' to list of imported records |
Description
Martin Renvoize
2022-10-13 12:35:03 UTC
The main page has a page-section now, but once you click through to a staged set the results table at the bottom of the page is not contained within such a div yet. Stealing this one from Martin... Created attachment 143968 [details] [review] Bug 31774: Add 'page-section' to list of imported records To test: * Stage a MARC file with a few records * Look at the import results * The list of imported records doesn't have the white page section background * Apply patch * Refresh page and verify the table now is contained Nice one Katrin, thought I might get to this one today with one of the new team but we didn't manage it so happy to see it stolen.. plenty more out there 😁 I'll get them to practice a signoff instead Created attachment 143993 [details] [review] Bug 31774: Add 'page-section' to list of imported records To test: * Stage a MARC file with a few records * Look at the import results * The list of imported records doesn't have the white page section background * Apply patch * Refresh page and verify the table now is contained Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 144002 [details] [review] Bug 31774: Add 'page-section' to list of imported records To test: * Stage a MARC file with a few records * Look at the import results * The list of imported records doesn't have the white page section background * Apply patch * Refresh page and verify the table now is contained Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Using this bug to work on sandboxes for a few minutes.. trying to get signoffs using the form input Created attachment 144004 [details] [review] Bug 31774: Add 'page-section' to list of imported records To test: * Stage a MARC file with a few records * Look at the import results * The list of imported records doesn't have the white page section background * Apply patch * Refresh page and verify the table now is contained Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I've sorted out the SO line to catch Jacob (one of our new devs) who actually tested and signed off on the bug on a sandbox during training today. Will keep bashing at fixing the sandboxes. Passing QA on the patch itself.. trivial and solid fix. Pushed to master for 22.11. Nice work everyone, thanks! *** Bug 32234 has been marked as a duplicate of this bug. *** |