Summary: | Typo in cleanup_database.pl cron's help/usage | ||
---|---|---|---|
Product: | Koha | Reporter: | Peter Vashchuk <stalkernoid> |
Component: | Architecture, internals, and plumbing | Assignee: | Peter Vashchuk <stalkernoid> |
Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | arthur.suzuki, david, lucas, wainuiwitikapark |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.08, 21.11.15
|
|
Circulation function: | |||
Attachments: |
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage
Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage |
Description
Peter Vashchuk
2022-10-13 14:37:09 UTC
Created attachment 141826 [details] [review] Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage cleanup_database.pl cronjob has a typo in it's usage/help: "preserve-logs" option should be "preserve-log" as it is everywhere in the code. Created attachment 141844 [details] [review] Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage cleanup_database.pl cronjob has a typo in it's usage/help: "preserve-logs" option should be "preserve-log" as it is everywhere in the code. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using koha-testing-docker): - Ran cronjob with --preserve-logs option and got error message: misc/cronjobs/cleanup_database.pl --preserve-logs Unknown option: preserve-logs - Ran cronjob with --preserve-log option and got message "You did not specify any cleanup work for the script to do." - Checked help after patch applied and help text is corrected (misc/cronjobs/cleanup_database.pl --help) Created attachment 141917 [details] [review] Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage cleanup_database.pl cronjob has a typo in it's usage/help: "preserve-logs" option should be "preserve-log" as it is everywhere in the code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi Petro, please don't forget to set Assignee! Created attachment 141954 [details] [review] Bug 31776: Fix a typo in cleanup_database.pl cronjob's help/usage cleanup_database.pl cronjob has a typo in it's usage/help: "preserve-logs" option should be "preserve-log" as it is everywhere in the code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.08 applied to 21.11 for 21.11.15 Not backported to 21.05.x |