Bug 31780

Summary: Add 'page-section' to audio alerts ( audio_alerts.tt )
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 30952    
Bug Blocks:    
Attachments: Bug 31780: Add page-section class to audio alerts
Bug 31780: Add page-section class to audio alerts
Bug 31780: Add page-section class to audio alerts

Description Lucas Gass (lukeg) 2022-10-13 19:56:02 UTC
We need the page-section div adding to audio alerts page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Lucas Gass (lukeg) 2022-10-13 19:59:47 UTC
Created attachment 141841 [details] [review]
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class added.

Note: There are some indentation changes.
Comment 2 David Nind 2022-10-13 21:39:07 UTC
Created attachment 141847 [details] [review]
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class added.

Note: There are some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2022-10-14 14:51:29 UTC
Created attachment 141893 [details] [review]
Bug 31780: Add page-section class to audio alerts

To test:

1. Apply the patch and go to Administration -> Audio alerts
2. Confirm that the screen/table look correct with the page-section class added.

Note: There are some indentation changes.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2022-10-14 15:02:23 UTC
Great work.. 

I wonder if the 'alert' div should be moved above the page heading and toolbar.. I've mentioned of irc we need a guideline for that.. alert box positions is another wildly inconsistent thing in Koha.
Comment 5 Tomás Cohen Arazi (tcohen) 2022-10-17 11:29:15 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!