Description
David Nind
2022-10-13 21:35:27 UTC
Created attachment 143778 [details] [review] Bug 31782: Fix patron autocomplete on patron list Test plan: Add new patrons to a patron list Created attachment 143779 [details] [review] Bug 31782: Fix patron autocomplete on order search Test plan: Search for order using the "Basket created by" field Created attachment 143780 [details] [review] Bug 31782: Fix autocomplete when duplicating orders Test plan: Add a new order to a basket from an existing order Search for the order to duplicate using the "Basket created by" field Created attachment 143781 [details] [review] Bug 31782: Remove js/autocomplete/patrons.js On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons route. A new patron_autocomplete JS function has been written (js/patron-autocomplete.js) for that purpose. However 3 occurrences were using an existing patron_autocomplete function, and 30578 didn't take care of adjusting correctly the call to the REST API route. On this patchset I am suggesting to copy/paste the JS functions defined in js/autocomplete/patrons.js, because we are very close of the 22.11 release. But ideally we should improve js/patron-autocomplete.js to add a new 'on-select-add-to' option that will take care of add/remove/hide behaviour. IMO that must be done on a separate bug, and after 22.11 is released (to not need to retest the other occurrences of the patron autocomplete) (In reply to Jonathan Druart from comment #5) > On this patchset I am suggesting to copy/paste the JS functions defined > in js/autocomplete/patrons.js, because we are very close of the 22.11 > release. But ideally we should improve js/patron-autocomplete.js to add > a new 'on-select-add-to' option that will take care of add/remove/hide > behaviour. IMO that must be done on a separate bug, and after 22.11 is > released (to not need to retest the other occurrences of the patron > autocomplete) See bug 32176. Created attachment 143782 [details] [review] Bug 31782: Fix patron autocomplete on patron list Test plan: Add new patrons to a patron list Signed-off-by: David Nind <david@davidnind.com> Created attachment 143783 [details] [review] Bug 31782: Fix patron autocomplete on order search Test plan: Search for order using the "Basket created by" field Signed-off-by: David Nind <david@davidnind.com> Created attachment 143784 [details] [review] Bug 31782: Fix autocomplete when duplicating orders Test plan: Add a new order to a basket from an existing order Search for the order to duplicate using the "Basket created by" field Signed-off-by: David Nind <david@davidnind.com> Created attachment 143785 [details] [review] Bug 31782: Remove js/autocomplete/patrons.js On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons route. A new patron_autocomplete JS function has been written (js/patron-autocomplete.js) for that purpose. However 3 occurrences were using an existing patron_autocomplete function, and 30578 didn't take care of adjusting correctly the call to the REST API route. On this patchset I am suggesting to copy/paste the JS functions defined in js/autocomplete/patrons.js, because we are very close of the 22.11 release. But ideally we should improve js/patron-autocomplete.js to add a new 'on-select-add-to' option that will take care of add/remove/hide behaviour. IMO that must be done on a separate bug, and after 22.11 is released (to not need to retest the other occurrences of the patron autocomplete) Signed-off-by: David Nind <david@davidnind.com> Created attachment 143806 [details] [review] Bug 31782: Fix patron autocomplete on patron list Test plan: Add new patrons to a patron list Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 143807 [details] [review] Bug 31782: Fix patron autocomplete on order search Test plan: Search for order using the "Basket created by" field Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 143808 [details] [review] Bug 31782: Fix autocomplete when duplicating orders Test plan: Add a new order to a basket from an existing order Search for the order to duplicate using the "Basket created by" field Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 143809 [details] [review] Bug 31782: Remove js/autocomplete/patrons.js On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons route. A new patron_autocomplete JS function has been written (js/patron-autocomplete.js) for that purpose. However 3 occurrences were using an existing patron_autocomplete function, and 30578 didn't take care of adjusting correctly the call to the REST API route. On this patchset I am suggesting to copy/paste the JS functions defined in js/autocomplete/patrons.js, because we are very close of the 22.11 release. But ideally we should improve js/patron-autocomplete.js to add a new 'on-select-add-to' option that will take care of add/remove/hide behaviour. IMO that must be done on a separate bug, and after 22.11 is released (to not need to retest the other occurrences of the patron autocomplete) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! *** Bug 32015 has been marked as a duplicate of this bug. *** |