Bug 31811

Summary: Add 'page-section' to MARC modification templates pages
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 30952    
Bug Blocks: 31757    
Attachments: Bug 31811: Add 'page-section' to MARC modification templates pages
Bug 31811: Add 'page-section' to MARC modification templates pages
Bug 31811: Add 'page-section' to MARC modification templates pages

Description Katrin Fischer 2022-10-15 08:11:26 UTC
We need the page-section div adding to the marc modification template page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Owen Leonard 2022-10-20 18:24:12 UTC
Created attachment 142276 [details] [review]
Bug 31811: Add 'page-section' to MARC modification templates pages

This patch adds "page-section" divs to the MARC modification templates
template so that sections are properly defined and content has adequate
contrast.

Note: The patch includes indentation changes, so please ignore
whitespace when checking the diff.

To test, apply the patch and go to Cataloging -> MARC modification
templates.

The main content should be surrounded by a white box whether you're
looking at the list of templates, the the action add/edit form.
Comment 2 David Nind 2022-10-20 19:09:50 UTC
Created attachment 142281 [details] [review]
Bug 31811: Add 'page-section' to MARC modification templates pages

This patch adds "page-section" divs to the MARC modification templates
template so that sections are properly defined and content has adequate
contrast.

Note: The patch includes indentation changes, so please ignore
whitespace when checking the diff.

To test, apply the patch and go to Cataloging -> MARC modification
templates.

The main content should be surrounded by a white box whether you're
looking at the list of templates, the the action add/edit form.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2022-10-21 09:20:18 UTC
Created attachment 142311 [details] [review]
Bug 31811: Add 'page-section' to MARC modification templates pages

This patch adds "page-section" divs to the MARC modification templates
template so that sections are properly defined and content has adequate
contrast.

Note: The patch includes indentation changes, so please ignore
whitespace when checking the diff.

To test, apply the patch and go to Cataloging -> MARC modification
templates.

The main content should be surrounded by a white box whether you're
looking at the list of templates, the the action add/edit form.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2022-10-21 09:21:04 UTC
`git diff -w` comes in handy with these paches ;p

All looks good, Passing QA
Comment 5 Tomás Cohen Arazi (tcohen) 2022-10-21 12:59:02 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!