| Summary: | Inconsistent table formatting for list of MARC imports | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> | 
| Component: | Staff interface | Assignee: | Owen Leonard <oleonard> | 
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> | 
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | 
       22.11.00 
 | 
        
        Circulation function: | |
| Bug Depends on: | 30952 | ||
| Bug Blocks: | 31833 | ||
| Attachments: | 
              Bug 31834: Replace incorrect "table" class from MARC imports table
               Bug 31834: Replace incorrect "table" class from MARC imports table Bug 31834: Replace incorrect "table" class from MARC imports table  | 
      ||
| 
 
        
          Description
        
        
          Katrin Fischer
        
        
        
        
          2022-10-16 12:31:31 UTC
        
       
    Created attachment 142515 [details] [review] Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the <table> tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a <thead> and <tbody>, with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. Looks better, and all the HTML is valid. My apologies as I think I was the one to add that 'table' class. Created attachment 142550 [details] [review] Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the <table> tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a <thead> and <tbody>, with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 142554 [details] [review] Bug 31834: Replace incorrect "table" class from MARC imports table The table containing staged MARC record batches has a "table" class added to the <table> tag, which is inconsistent with other tables in the staff interface. The class pulls in default table styles from Bootstrap which aren't consistent. There are a few other non-DataTable tables have the the class "dataTable" added in order to make them more consistent. I think this table should have that class too. The template is also modified to give the table a <thead> and <tbody>, with indentation corrected accordingly. To test, apply the patch and go to Cataloging -> Manage staged records. The table of staged records should look correct, with style matching DataTables elsewhere in Koha, e.g. Administration -> Libraries. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks!  |