Summary: | Show creator and budget receiving a document | ||
---|---|---|---|
Product: | Koha | Reporter: | Nahuel Angelinetti <nahuel.angelinetti> |
Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P4 | CC: | chris, duncan, koha.sekjal, paul.poulain, wizzyrea |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
bugfix for 3.0.x
receive page without user and budget screenshot of receive page screenshot of order receive page with creator name and fund Bug 3184: Show creator and budget on order receive page Bug 3184: Show creator and budget on order receive page Bug 3184: Show creator and budget on order receive page Signed off patch |
Description
Chris Cormack
2010-05-21 01:07:26 UTC
I can't find the patch in current master and I see no information about basket creator or budget on the receive page. Changing version as 3.0.x is no longer maintained. Attached patch is still for 3.2.x and probably needs to reimplemented. Created attachment 5020 [details]
screenshot of receive page
Created attachment 6089 [details]
screenshot of order receive page with creator name and fund
I reimplemented the patch for current master. Attached screenshot shows changes.
Created attachment 6091 [details] [review] Bug 3184: Show creator and budget on order receive page Reimplementing 3.0.x patch from Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com> To test: 1) Create basket 2) Order something, note your fund 3) Receive title > Verify your name and selected fund display correctly Previous patch had wrong bug number! Created attachment 6095 [details] [review] Bug 3184: Show creator and budget on order receive page Reimplementing 3.0.x patch from Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com> To test: 1) Create basket 2) Order something, note your fund 3) Receive title > Verify your name and selected fund display correctly Previous patch had wrong bug number! Signed-off-by: Liz Rea <lrea@nekls.org> I verify that with this patch, the name and fund are displayed on the order receive display. This patch falls victim to the same issue as bug 6390: there is no way to ensure that authorisedby is a value borrowernumber. The borrower could have been deleted, or if the koha database user account was used, then there would be no GetMember record to view. This will lead to the "Can't use an undefined value as a HASH reference" error, breaking the page. Please provide a fall-back value for the $member hash in the event the authorisedby value is not a valid borrowernumber. Created attachment 6438 [details] [review] Bug 3184: Show creator and budget on order receive page Reimplementing 3.0.x patch from Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com> To test: 1) Create basket 2) Order something, note your fund 3) Receive title > Verify your name and selected fund display correctly Additional tests: 1) Set borrowernumber in aqbasket.authorisedby to a nonexistant borrowernumber (like something really big) > Created by should show "No name" 2) Set borrowernumber to NULL / empty > Created by should show "No name" Created attachment 6763 [details] [review] Signed off patch Fetches borrower using 'authorisedby', which will not always work. Thankfully, default values are provided for firstname and surname, so in the event of a deleted borrower, this shouldn't cause problems. Other than recommending a note above the GetMember line to document the above, I have no other recommendations for this patch. Marking Passed QA. Patch pushed, please test QA comment: checked perlcritic & valid template are still OK: perlcritic acqui/orderreceive.pl acqui/orderreceive.pl source OK prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok |