| Summary: | Invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Chris Cormack <chris> |
| Component: | Notices | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fred.pierre, fridolin.somers, jonathan.druart, jwagner, mtj, olli-antti.kivilahti, tomascohen |
| Version: | Main | ||
| Hardware: | PC | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
pätch
pätch Bug 3186 - invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail [PASSED QA] Bug 3186 [QA Followup] - Don't return undef, just return [PASSED QA] Bug 3186 - invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail [PASSED QA] Bug 3186 [QA Followup] - Don't return undef, just return |
||
|
Description
Chris Cormack
2010-05-21 01:07:27 UTC
This also happens when the smsalertnumber is of the following format: 040-12345678(mother) This is caused by the /usr/share/perl5/SMS/Send.pm parent object for sms sending. It tries to validate the number and Croacks the process dead when (mother) is encountered. Luckily verbose mode outputs goog logging info :) Recommending to add a presentation layer validator to OPAC and SC to make sure no mothers are included. Created attachment 31191 [details] [review] pätch Created attachment 31192 [details] [review] pätch Fixed an issue with return not working as expected inside an eval-block Created attachment 31216 [details] [review] Bug 3186 - invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail This patch wraps the SMS::Send Driver initialization and sending process into an eval block and gracefully causes the sending to fail, instead of crashing the process and preventing emails and good sms' from being sent. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 31290 [details] [review] [PASSED QA] Bug 3186 [QA Followup] - Don't return undef, just return Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 31291 [details] [review] [PASSED QA] Bug 3186 - invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail This patch wraps the SMS::Send Driver initialization and sending process into an eval block and gracefully causes the sending to fail, instead of crashing the process and preventing emails and good sms' from being sent. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 31292 [details] [review] [PASSED QA] Bug 3186 [QA Followup] - Don't return undef, just return Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patches pushed to master. Thanks Olli! Must be my lucky week! Mason, Fridolin, IMO it makes sense to backport this one. (In reply to Jonathan Druart from comment #10) > Mason, Fridolin, > IMO it makes sense to backport this one. cheers, i'll take a look (In reply to Mason James from comment #11) > (In reply to Jonathan Druart from comment #10) > > Mason, Fridolin, > > IMO it makes sense to backport this one. > > cheers, i'll take a look Pushed to 3.16.x branch. Patch will be in included in 3.16.8 release I feel like there are two bugs here - the missing SMS driver, which is patched and the bad number format, which is not. Could we split that out as a separate bug? It would be pretty easy to regex the number before we drop it into the database. I understand that phone numbers are often stored as text, because of hyphens and parentheses, but if stray symbols break the whole overdue notifications process, we might want to strip phone numbers down to the digits. *** Bug 14611 has been marked as a duplicate of this bug. *** |