Bug 31860

Summary: Standardize capitalization for item subfield descriptions (UNIMARC 995/MARC21 952)
Product: Koha Reporter: David Nind <david>
Component: MARC Bibliographic data supportAssignee: Katrin Fischer <katrin.fischer>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: trivial    
Priority: P5 - low CC: martin.renvoize
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Attachments: Bug 31860: Standardize capitalization used for item subfield descriptions
Bug 31860: Standardize capitalization used for item subfield descriptions
Bug 31860: Standardize capitalization used for item subfield descriptions

Description David Nind 2022-10-18 19:09:39 UTC
The label for Serial enumeration / chronology (952$h) is displayed as "Serial Enumeration / chronology" - note the capital "E".

For consistency, this should be displayed in sentence case wherever it is required in the staff interface and OPAC, including:
- details view in the staff interface: MARC view, edit items table, add and edit item form
- MARC view in the OPAC: holdings table

Note: Libraries can update this themselves by updating $952$h for all the frameworks it is used in.
Comment 1 Katrin Fischer 2023-02-06 22:31:56 UTC
Created attachment 146304 [details] [review]
Bug 31860: Standardize capitalization used for item subfield descriptions

This standardizes "Total Holds" to "Total holds" etc.
Also changed is UNIMARC
* "Collection code" to "Collection" like MARC21
* "Current Location" to "Current library" like MARC21 (holdingbranch)
* "Permanent Location" to "Home library" like MARC21 (homebranch)

To test:
* You'll need to apply the patch and then run the web installer to
  create your frameworks
* Once you got a fresh installation, got to
  Administration > Bibliographic frameworks > Choose any
* Go to 995 (for UNIMARC) or 952 (for MARC21)
* Check the descriptions of the subfields for capitalization and
  spelling errors

https://bugs.koha-community.org/show_bug.cgi?id=31768
Comment 2 David Nind 2023-02-07 09:25:36 UTC
Created attachment 146308 [details] [review]
Bug 31860: Standardize capitalization used for item subfield descriptions

This standardizes "Total Holds" to "Total holds" etc.
Also changed is UNIMARC
* "Collection code" to "Collection" like MARC21
* "Current Location" to "Current library" like MARC21 (holdingbranch)
* "Permanent Location" to "Home library" like MARC21 (homebranch)

To test:
* You'll need to apply the patch and then run the web installer to
  create your frameworks
* Once you got a fresh installation, got to
  Administration > Bibliographic frameworks > Choose any
* Go to 995 (for UNIMARC) or 952 (for MARC21)
* Check the descriptions of the subfields for capitalization and
  spelling errors

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-02-07 09:32:27 UTC
Thanks Katrin for spotting the other occurrences that needed updating!

The only one I wasn't sure about was URI, and whether it should be capitalised when spelt in full. The dictionaries and other resources I looked up were inconclusive...

Also, I amended the commit message to remove the Bugzilla link after the test plan to bug 31768.

Testing notes (using KTD):

1. After applying the patch, I did a reset_all - this loaded the updated text for the descriptions.

2. To test the UNIMARC changes (955) I amended the KTD .env file to change KOHA_MARC_FLAVOUR=unimarc and then started up KTD to get a UNIMARC instance.
Comment 4 Katrin Fischer 2023-02-07 10:14:28 UTC
> The only one I wasn't sure about was URI, and whether it should be
> capitalised when spelt in full. The dictionaries and other resources I
> looked up were inconclusive...

I was not completely sure either. Can't we just update the label to URI or URL? :)
> 
> Also, I amended the commit message to remove the Bugzilla link after the
> test plan to bug 31768.

Thanks, that was due to me having a bug typo first.
 
> Testing notes (using KTD):
> 
> 1. After applying the patch, I did a reset_all - this loaded the updated
> text for the descriptions.
> 
> 2. To test the UNIMARC changes (955) I amended the KTD .env file to change
> KOHA_MARC_FLAVOUR=unimarc and then started up KTD to get a UNIMARC instance.
Comment 5 Martin Renvoize 2023-02-07 12:46:25 UTC
Created attachment 146317 [details] [review]
Bug 31860: Standardize capitalization used for item subfield descriptions

This standardizes "Total Holds" to "Total holds" etc.
Also changed is UNIMARC
* "Collection code" to "Collection" like MARC21
* "Current Location" to "Current library" like MARC21 (holdingbranch)
* "Permanent Location" to "Home library" like MARC21 (homebranch)

To test:
* You'll need to apply the patch and then run the web installer to
  create your frameworks
* Once you got a fresh installation, got to
  Administration > Bibliographic frameworks > Choose any
* Go to 995 (for UNIMARC) or 952 (for MARC21)
* Check the descriptions of the subfields for capitalization and
  spelling errors

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize 2023-02-07 12:47:32 UTC
Looks good to me.. Passing QA
Comment 7 Tomás Cohen Arazi 2023-02-07 13:50:55 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-02-08 16:37:35 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.