Summary: | Table controls on checkouts table are buttons | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 31754 | ||
Bug Blocks: | 31962 | ||
Attachments: |
Screenshot of checkouts table
Bug 31861: Table controls on checkouts table are buttons Bug 31861: Table controls on checkouts table are buttons Bug 31861: Table controls on checkouts table are buttons Bug 31861: (follow-up) Fix disabled clear search button Bug 31861: (follow-up) Fix disabled clear search button |
Created attachment 142192 [details] [review] Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. Created attachment 142198 [details] [review] Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. Signed-off-by: David Nind <david@davidnind.com> Created attachment 142359 [details] [review] Bug 31861: Table controls on checkouts table are buttons This patch updates the style of DataTables buttons (columns, export, and configure), in cases where the buttons are the only control being displayed (no page controls, filter, etc). To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Go to Circulation and check an item out to a patron. - If necessary, click the "Show checkouts" button to reveal the table of checkouts. - The "Columns," "Export," and "Configure" controls should look the same as they do in other situations, with no button-style border. - Go to Circulation -> Check in and check in the item. The table of checked-in items should show the same style controls. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Resolves issue found, improves consistency and no regressions found. Passing QA OK.. there is a regression here.. The 'Clear filter' link becomes a button again after this patch.. and causes page jiggle.. this seems to undo something fixed in bug 31754 Created attachment 142495 [details] [review] Bug 31861: (follow-up) Fix disabled clear search button The disabled clear search button should not have a border and background set. Created attachment 142497 [details] [review] Bug 31861: (follow-up) Fix disabled clear search button The disabled clear search button should not have a border and background set. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks for quick follow-up.. PQA now :) Pushed to master for 22.11. Nice work everyone, thanks! |
Created attachment 142088 [details] Screenshot of checkouts table The table controls to export, print and change columns on the checkouts table in patron account look much different to the table controls on other tables.