Bug 31865

Summary: Hide display of 'dev/testing' packages on production installs
Product: Koha Reporter: Mason James <mtj>
Component: AboutAssignee: Mason James <mtj>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: dcook, jonathan.druart, pedro.amorim, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 31865: hide development modules
Bug 31865: add develop section to cpanfile
Bug 31865: add 'develop' section to cpanfile
Bug 31865: hide development modules
dev_install=0
Bug 31865: add 'develop' section to cpanfile
Bug 31865: add 'develop' section to cpanfile

Description Mason James 2022-10-19 03:20:05 UTC
this patchset attempts to hide the display of 'dev/testing' packages on production installs

this will hopefully reduce situations where dev/testing packages are installed from CPAN, which can introduce problems
Comment 3 Mason James 2022-10-19 04:52:10 UTC
Created attachment 142130 [details] [review]
Bug 31865: add 'develop' section to cpanfile
Comment 4 Mason James 2022-10-19 04:52:15 UTC
Created attachment 142131 [details] [review]
Bug 31865: hide development modules
Comment 5 Mason James 2022-10-19 04:59:52 UTC
(In reply to Mason James from comment #0)
> this patchset attempts to hide the display of 'dev/testing' packages on
> production installs
> 
> this will hopefully reduce situations where dev/testing packages are
> installed from CPAN, which can introduce problems

to test:

- apply patchset

- start KTD

- observe apache::bench module in about.pl->modules

- fake 'production' install by adding the following code in about.pl, line 660

660 $ENV{DEV_INSTALL} = 0;  <<<<<<<<<<<<<
661 foreach my $pm_type(@pm_types) {
662     my $modules = $perl_modules->get_attr($pm_type);

- restart plack

- observe apache::bench module is *not* in about.pl->modules
Comment 6 Mason James 2022-10-19 05:03:44 UTC
Created attachment 142132 [details]
dev_install=0
Comment 7 David Cook 2022-10-19 06:11:50 UTC
Haven't looked at the patches but I like the idea.
Comment 8 Jonathan Druart 2022-10-19 08:12:22 UTC
Maybe better to still display them but separately?
Comment 9 Pedro Amorim 2023-02-07 15:13:58 UTC
Patch no longer applies, HTTPD::Bench::ApacheBench was removed by bug 32673.
Comment 10 Mason James 2023-02-12 10:51:08 UTC
Created attachment 146553 [details] [review]
Bug 31865: add 'develop' section to cpanfile
Comment 11 Mason James 2023-02-12 11:08:02 UTC
Created attachment 146554 [details] [review]
Bug 31865: add 'develop' section to cpanfile
Comment 12 Pedro Amorim 2023-02-13 09:43:14 UTC
Should this go back to "Needs sign-off"?
What about Jonathan's suggestion of displaying them, but separately?

My understanding is (please correct if I'm wrong) that even in a production environment, these dev modules will still be installed.
If this is the case, I agree with Jonathan in that these should be listed separately, instead of hidden, as they are indeed installed - even if just needed for dev.