Summary: | Cleaning up t/db_dependent/Context.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Test Suite | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.11.00
|
Circulation function: | |
Attachments: |
Bug 31870: Groundwork for Context.t
Bug 31870: Context.t: Fix indentation, remove old comments Bug 31870: Context.t: Reorganize subtests Bug 31870: Add license, remove unused modules Bug 31870: Groundwork for Context.t Bug 31870: Context.t: Fix indentation, remove old comments Bug 31870: Context.t: Reorganize subtests Bug 31870: Add license, remove unused modules |
Description
Marcel de Rooy
2022-10-19 11:42:10 UTC
Moving some work here that I intended to go with a rework of 31784. Created attachment 142149 [details] [review] Bug 31870: Groundwork for Context.t Replacing the vars statement. Adding a larger subtest. Removing TransformVersionToNum. Test plan: Run t/db_dependent/Context.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 142150 [details] [review] Bug 31870: Context.t: Fix indentation, remove old comments Test plan: Run test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 142151 [details] [review] Bug 31870: Context.t: Reorganize subtests Move a few tests into separate subtests. Replace the BEGIN block. Test plan: Run test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 142152 [details] [review] Bug 31870: Add license, remove unused modules Test plan: Run test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Architectural + trivial, self SO Created attachment 142453 [details] [review] Bug 31870: Groundwork for Context.t Replacing the vars statement. Adding a larger subtest. Removing TransformVersionToNum. Test plan: Run t/db_dependent/Context.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 142454 [details] [review] Bug 31870: Context.t: Fix indentation, remove old comments Test plan: Run test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 142455 [details] [review] Bug 31870: Context.t: Reorganize subtests Move a few tests into separate subtests. Replace the BEGIN block. Test plan: Run test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 142456 [details] [review] Bug 31870: Add license, remove unused modules Test plan: Run test again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement won't be backported to 22.05.x series |