Bug 31881

Created attachment 142219 [details] [review]
Bug 31881: Fix search link in MARC view

In framework a subfield can be defined with a link (with a search field).
This create an hyperlink in MARC view.
Currently with Elasticsearch the link does not work because search query contains 'field,phr:',
which is useless since the link contains 'idx=field,phr'.
With Zebra looks like the idx param is ignored.

Test plan :
1) Use Elasticsearch search engine
2) Edit subfield 245$a in default framework
3) Enter 'title' in 'Link'
4) Save
5) Create a record with default framework with 245$a = 'The Fifth Elephant'
6) Go to MARC view
7) Click on link in 245$a
8) You find the record

Created attachment 142246 [details] [review]
Bug 31881: Fix search link in MARC view

In framework a subfield can be defined with a link (with a search field).
This create an hyperlink in MARC view.
Currently with Elasticsearch the link does not work because search query contains 'field,phr:',
which is useless since the link contains 'idx=field,phr'.
With Zebra looks like the idx param is ignored.

Test plan :
1) Use Elasticsearch search engine
2) Edit subfield 245$a in default framework
3) Enter 'title' in 'Link'
4) Save
5) Create a record with default framework with 245$a = 'The Fifth Elephant'
6) Go to MARC view
7) Click on link in 245$a
8) You find the record

Signed-off-by: David Nind <david@davidnind.com>

Not created here, but how ugly is this:
[% IF ( subfiel.link ) %]

subfiel ??

Currently with Elasticsearch the link does not work because search query contains 'field,phr:',
which is useless since the link contains 'idx=field,phr'.

Not sure about this one. Are we really resolving the problem or just creating a workaround?

You say that the query contains 'field'. Isnt that just misconfiguration? The framework column link should contain a valid index?

Please clarify.

(In reply to Marcel de Rooy from comment #4)
> Currently with Elasticsearch the link does not work because search query
> contains 'field,phr:',
> which is useless since the link contains 'idx=field,phr'.
> 
> Not sure about this one. Are we really resolving the problem or just
> creating a workaround?
> 
> You say that the query contains 'field'. Isnt that just misconfiguration?
> The framework column link should contain a valid index?
> 
> Please clarify.

Sure.

In test plan, framework column link contains 'title' which is a valid 'index' (= search field).
Actually the build search link contains the search field twice :
&idx=title,phr
&q=title,phr:...

I think we want to build a search query like it as been created from advanced search. So keep '&idx' and remove search field from '&q'.

Created attachment 143174 [details] [review]
Bug 31881: Fix search link in MARC view

In framework a subfield can be defined with a link (with a search field).
This create an hyperlink in MARC view.
Currently with Elasticsearch the link does not work because search query contains 'field,phr:',
which is useless since the link contains 'idx=field,phr'.
With Zebra looks like the idx param is ignored.

Test plan :
1) Use Elasticsearch search engine
2) Edit subfield 245$a in default framework
3) Enter 'title' in 'Link'
4) Save
5) Create a record with default framework with 245$a = 'The Fifth Elephant'
6) Go to MARC view
7) Click on link in 245$a
8) You find the record

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

(In reply to Fridolin Somers from comment #5)
> I think we want to build a search query like it as been created from
> advanced search. So keep '&idx' and remove search field from '&q'.

Great. Thanks.

Pushed to master for 22.11.

Nice work everyone, thanks!

Backported to 22.05.x for upcoming 22.05.09

pushed to 21.11.x for 21.11.16

Not backported to 21.05.x