Summary: | PrefillGuaranteeField should include option to prefill surname | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Patrons | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, gmcharlt, kyle.m.hall, kyle, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This bugfix adds the surname field to the list of fields (in the PrefillGuaranteeField system preference) that can be automatically prefilled when adding a guarantee to a patron's account.
|
|
Version(s) released in: |
23.05.00,22.11.04
|
Circulation function: | |
Attachments: |
Bug 31890: Add surname to PrefillGuaranteeField system pref
Bug 31890: Add surname to PrefillGuaranteeField system pref Bug 31890: Add surname to PrefillGuaranteeField system pref |
Description
Lucas Gass (lukeg)
2022-10-20 14:47:57 UTC
Created attachment 144725 [details] [review] Bug 31890: Add surname to PrefillGuaranteeField system pref To test: 1. Apply patch and restart_all 2. Find the system preference PrefillGuaranteeField 3. Look for the Surname option and add it 4. Go to a patron account and add a gaurantee 5. See that the surname is properly populated for the gaurantor's surname field Note: This patch replaces borrower_data.surname with patron.surname. There seems to be a mismatch here so I filed Bug 32458. Created attachment 144728 [details] [review] Bug 31890: Add surname to PrefillGuaranteeField system pref To test: 1. Apply patch and restart_all 2. Find the system preference PrefillGuaranteeField 3. Look for the Surname option and add it 4. Go to a patron account and add a gaurantee 5. See that the surname is properly populated for the gaurantor's surname field Note: This patch replaces borrower_data.surname with patron.surname. There seems to be a mismatch here so I filed Bug 32458. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Step 4: Showing my lack of knowledge (for whatever reason, I originally couldn't work out how to do this!) - to add a guarantee to a patron: 1.1 Go to a patron's account (such as Mary Burton) 1.2 Click the '+ Add guarantee' option after the 'Edit' option Created attachment 146511 [details] [review] Bug 31890: Add surname to PrefillGuaranteeField system pref To test: 1. Apply patch and restart_all 2. Find the system preference PrefillGuaranteeField 3. Look for the Surname option and add it 4. Go to a patron account and add a gaurantee 5. See that the surname is properly populated for the gaurantor's surname field Note: This patch replaces borrower_data.surname with patron.surname. There seems to be a mismatch here so I filed Bug 32458. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 23.05. Nice work everyone, thanks! Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release Enhancement will not be backported to 22.05.x |