Bug 31907

Summary:	Show items as On hold when in processing
Product:	Koha	Reporter:	Stefan Berndtsson <stefan.berndtsson>
Component:	OPAC	Assignee:	Stefan Berndtsson <stefan.berndtsson>
Status:	CLOSED FIXED	QA Contact:	Martin Renvoize (ashimema) <martin.renvoize>
Severity:	normal
Priority:	P5 - low	CC:	david, magnus, martin.renvoize
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00
Circulation function:
Attachments:	Bug 31907: Show items as On hold when in processing Bug 31876: Fix capitalization "Click to Expand Tag" Bug 31907: Show items as On hold when in processing Bug 31907: Show items as On hold when in processing Bug 31907: (QA follow-up) Add POD Bug 31907: (QA follow-up) Simplify tests

Description Stefan Berndtsson 2022-10-21 12:20:36 UTC

The addition of the Processing reserve status should show status in Opac as On hold, just like it does for Waiting.

This patch adds that to item list in opac-detail and opac-basket.

Comment 1 Stefan Berndtsson 2022-10-21 12:21:13 UTC

Created attachment 142339 [details] [review]
Bug 31907: Show items as On hold when in processing

Test plan:
1. Make sure syspref "opacbookbag" is set to "Allow".
2. Make sure syspref "HoldsNeedProcessingSIP" is set to "Don't fulfill".
3. Place a hold on an item.
4. Return item via SIP at the pickup library.
5. View biblio in Opac.
6. Note that it says "Available" as status.
7. Add biblio to Cart.
8. Open Cart.
9. Note that it says "Available" as status.
10. Apply patch.
11. Reload Opac page.
12. It should now say "On hold".
13. Reload Card page.
14. It should also say "On hold".

Comment 2 Katrin Fischer 2022-10-24 20:35:46 UTC Comment hidden (obsolete)

Created attachment 142567 [details] [review]
Bug 31876: Fix capitalization "Click to Expand Tag"

The string "Click to Expand this Tag" appears in addbiblio.tt a couple of times. It should be "Click to expand this tag".

To get to the string for the staff interface:
1. In the staff interface, go to Cataloging
2. Click "New record"
3. Hover the mouse cursor over one of the tag titles (e.g. CONTROL NUMBER)
   --> a little popup thing (tooltip?) appears with "Click to Expand this Tag"
4. Go to Administration > Global system preferences
5. Search for advancedMARCeditor
6. Change the value to "Don't show"
7. Click "Save all Cataloging preferences"
8. Go back to Cataloging > New record
9. Hover the mouse cursor over the tag number (e.g. 001)
   --> a little popup thing (tooltip?) appears with "<tag title> Click to Expand this Tag"
10. Go to Authorities > new record
11. Hover over the desription of a tag which subfields are collapsed
   --> verify the tooltip appears with "Click to Expand this Tag"
12. Apply patch, all occurrences should be fixed now.

Comment 3 David Nind 2022-10-31 00:39:08 UTC

Created attachment 142821 [details] [review]
Bug 31907: Show items as On hold when in processing

Test plan:
1. Make sure syspref "opacbookbag" is set to "Allow".
2. Make sure syspref "HoldsNeedProcessingSIP" is set to "Don't fulfill".
3. Place a hold on an item.
4. Return item via SIP at the pickup library.
5. View biblio in Opac.
6. Note that it says "Available" as status.
7. Add biblio to Cart.
8. Open Cart.
9. Note that it says "Available" as status.
10. Apply patch.
11. Reload Opac page.
12. It should now say "On hold".
13. Reload Card page.
14. It should also say "On hold".

Signed-off-by: David Nind <david@davidnind.com>

Comment 4 David Nind 2022-10-31 00:41:58 UTC

Testing notes using koha-testing-docker (KTD):

1. Check that SIP is running (should be if using KTD): koha-sip --status kohadev

2. I used item 39999000001310 (biblionumber = 29) from CPL to test, hold placed for pick up at CPL

3. For step 4, command using misc/sip_cli_emulator.pl to return item: misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkin --item 39999000001310

4. For step 10, after applying the patch I ran flush_memcached and restart_all

Note: I obsoleted comment #2, as it was a patch for another bug incorrectly added to this bug.

Comment 5 Martin Renvoize (ashimema) 2022-11-02 17:06:19 UTC

Created attachment 143018 [details] [review]
Bug 31907: Show items as On hold when in processing

Test plan:
1. Make sure syspref "opacbookbag" is set to "Allow".
2. Make sure syspref "HoldsNeedProcessingSIP" is set to "Don't fulfill".
3. Place a hold on an item.
4. Return item via SIP at the pickup library.
5. View biblio in Opac.
6. Note that it says "Available" as status.
7. Add biblio to Cart.
8. Open Cart.
9. Note that it says "Available" as status.
10. Apply patch.
11. Reload Opac page.
12. It should now say "On hold".
13. Reload Card page.
14. It should also say "On hold".

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 6 Martin Renvoize (ashimema) 2022-11-02 17:06:23 UTC

Created attachment 143019 [details] [review]
Bug 31907: (QA follow-up) Add POD

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 7 Martin Renvoize (ashimema) 2022-11-02 17:07:15 UTC

All works as expected, Unit tests included and QA script happy once the follow-up was added.

Passing QA

Comment 8 Tomás Cohen Arazi (tcohen) 2022-11-04 23:19:26 UTC

Created attachment 143296 [details] [review]
Bug 31907: (QA follow-up) Simplify tests

This patch simplipfies the tests, and highlighs the fact the introduced
method should add filters to the current resultset.

It also aligns the tests with the currently adopted style.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 9 Tomás Cohen Arazi (tcohen) 2022-11-04 23:21:37 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!

Comment 10 Magnus Enger 2022-12-30 10:36:28 UTC

Any chance of a backport to 22.05 and 21.11? (I have not tested, but a library has reported that this is a problem in 21.11)