| Summary: | Unit test t/db_dependent/Holds.t leaves behind database cruft | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, david, lucas, m.de.rooy, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.08, 21.11.15
|
|
| Circulation function: | |||
| Bug Depends on: | 30447 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t
Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t |
||
|
Description
Kyle M Hall (khall)
2022-10-21 15:29:49 UTC
Created attachment 142409 [details] [review] Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t A subest in t/db_dependent/Holds.t leaves behind database cruft. Test Plan: Using koha-testing-docker: 1) SELECT branchcode FROM branches 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches Note cruft 4) reset_all 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches No cruft! Created attachment 142442 [details] [review] Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t A subest in t/db_dependent/Holds.t leaves behind database cruft. Test Plan: Using koha-testing-docker: 1) SELECT branchcode FROM branches 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches Note cruft 4) reset_all 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches No cruft! Signed-off-by: David Nind <david@davidnind.com> Testing notes: - Step 4.5: Apply patch Thanks a lot Kyle :) Created attachment 142450 [details] [review] Bug 31920: Add transaction to subtest in t/db_dependent/Holds.t A subest in t/db_dependent/Holds.t leaves behind database cruft. Test Plan: Using koha-testing-docker: 1) SELECT branchcode FROM branches 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches Note cruft 4) reset_all 2) prove t/db_dependent/Holds.t 3) SELECT branchcode FROM branches No cruft! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.08 applied to 21.11 for 21.11.15 Not backported to 21.05.x |