Summary: | 'Ignore' tab description is misleading | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | System Administration | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | david, gmcharlt, lauren_denny, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27730 | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. This is the normal behavior of the 'Ignore' tab, it has not changed. Only the description was updated to reflect it's actual behavior.
|
Version(s) released in: |
22.11.00
|
Circulation function: | |||
Attachments: |
Bug 31923: 'Ignore' tab description is misleading
Bug 31923: 'Ignore' tab description is misleading Bug 31923: 'Ignore' tab description is misleading Bug 31923: 'Ignore' tab description is misleading Bug 31923: 'Ignore' tab description is misleading Bug 31923: 'Ignore' tab description is misleading Bug 31923: 'Ignore' tab description is misleading Bug 31923: Add warning sign and span Bug 31923: 'Ignore' tab description is misleading Bug 31923: Add warning sign and span |
Description
Caroline Cyr La Rose
2022-10-21 18:21:36 UTC
To see the Ignore tab in action, 1. Catalog a record with, for example, a value in 020$a 2. Save the record in MARCXML and view it in a text editor --> The 020$a subfield is there 3. Go to Administration > MARC bibliographic framework 4. Edit 020$a and put it in the 'Ignore' tab 5. Edit the record --> The 020$a field is not there anymore, which is normal and what the current description says 6. Don't change anything and save the record 7. Save the record in MARCXML and view it in a text editor --> The 020$a subfield is gone completely Created attachment 142440 [details] [review] Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Hi Caroline. Everything works as per the test plan. For the grammar, "..it's.." should be "..its..". This is one of English's idiosyncrasies - would read as "..it is.." if expanded out, rather than the possessive! https://www.grammarly.com/blog/its-vs-its/ I was thinking, if possible, it may be useful to add a warning symbol before the text (the triangle icon with an exclamation mark), similar to what is on the Tools > Log viewer page. I've also changed the assignee to you. Thanks for creating the bug and fix from the IRC conversation (http://irc.koha-community.org/koha/2022-10-20#i_2457304). I think that the option "Managed in tab: ignore" is quite misleading (but I can't think of a better option name that makes sense), as: - there is no "ignore" tab, and - it removes any values if the record is saved! Testing notes (using koha-testing-docker): - Record used for testing bibliographic record: 262 (Programming Perl), has an 020$a value - Record used for testing an authority record: 1525 (Perl (Computer language)), used 040$c David Created attachment 142444 [details] [review] Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Created attachment 142445 [details] [review] Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. Hi David! Thanks for testing! I corrected the "its". I also added a second commit with the warning sign. I wasn't sure how to put a space between the warning sign and the sentence... Maybe someone could help? Thanks! Caroline Created attachment 142446 [details] [review] Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. Created attachment 142447 [details] [review] Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Created attachment 142448 [details] [review] Bug 31923: 'Ignore' tab description is misleading This patch adds a small warning sign before the sentence and also puts the sentence inside a span. I think I managed the space, but I'm not sure if it is the right way to do it... Also I had to flex my (teeny tiny) git muscles quite a lot so I hope my submissions are OK! Created attachment 142466 [details] [review] Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Signed-off-by: David Nind <david@davidnind.com> Created attachment 142467 [details] [review] Bug 31923: Add warning sign and span This patch adds a small warning sign before the sentence and also puts the sentence inside a span. Signed-off-by: David Nind <david@davidnind.com> (In reply to Caroline Cyr La Rose from comment #10) > I think I managed the space, but I'm not sure if it is the right way to do > it... Also I had to flex my (teeny tiny) git muscles quite a lot so I hope > my submissions are OK! It looks OK to me, and the patch applied cleanly. I changed the title of the commit message for the second patch so that it is different from the main patch. Created attachment 142565 [details] [review] Bug 31923: 'Ignore' tab description is misleading This patch modifies the description of the 'Ignore' tab in MARC bibliographic and authority framework administration to add that not only does the 'ignored' subfield not appear in the editor, but the subfield will also be deleted from the record. To test: 1. Go to Administration > MARC bibliographic framework 2. Click 'Actions' next to any framework and choose 'MARC structure' 3. Click 'Actions' next to any field and choose 'Edit subfields' 4. Check the hint/description under 'Managed in tab' and make sure it - makes sense - is written in correct english (syntax and spelling) - mentions that the subfield's value will be deleted from the record 5. Go to Administration > Authority types 6. Redo steps 2-4 for authority frameworks Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 142566 [details] [review] Bug 31923: Add warning sign and span This patch adds a small warning sign before the sentence and also puts the sentence inside a span. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |